-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking ionic serve doesn't close the connection #3401
Comments
I'm having the same issue since the version '4.0.0-rc.11'. The version '4.0.0-rc.10' works fine for me. My ionic info:
|
I closed #3022 in favor of this one, because it already has better repro steps, information, etc. This is the first time I've seen it happen on a non-Windows machine @lordgreg FWIW, I've never seen this on my machine, but several people have reported it. @lordgreg @adailtonribeiro Could you paste the output of @adailtonribeiro Interesting. I did change some things related to serve in rc.10 -> rc.11. @lordgreg Would you mind installing those and seeing if you see the same thing? My
|
@dwieeb I didn't find a similar command for windows but I think the ionic-app-scripts is shutting down properly because when I run Using ionic CLI 4.0.1 and project type 'ionic-angular' (v3)
Also ionic CLI 4.0.1 is not shutting down for project type 'angular' (v4) My
|
@adailtonribeiro Thanks! Would you mind pasting the last bit of output of
|
@lordgreg If you send TERM signal to the process, is it killed? Try |
@dwieeb Thank you, here's the info you requested:
And, as you can see, its about the One thing to take into the consideration, why am I taking another port? Because Killing it, as you'we wrote, kills the process.
|
@dwieeb Running However, if I use the ionic CLI 4.0.0-rc.10 after pressing (Ctrl + C) show those lines:
|
@lordgreg Do you see "SIGINT received" in the verbose output? I have found if the @lordgreg What is the output of @adailtonribeiro On Windows it's a bit different, I'm not exactly sure how NodeJS maps these signals. That's helpful, though. Do you see Thank you both again for helping debug this. It is difficult to debug an issue I cannot reproduce on my own computer! |
@dwieeb sorry for the late response, After running
Here's the result when breaking the script (CTRL+C):
The |
Thank you @lordgreg @lordgreg @adailtonribeiro When you get a chance, please try this testing release to see if the issue is resolved:
|
@dwieeb I've tested the version also running My
My
|
@adailtonribeiro Thank you for testing. I added some more debug statements that may print. Can you paste the last bit of output after you use Ctrl-C on |
@dwieeb Hi, I've updated both (global and local) versions to your hash. Starting and cancelling the ionic serve:
Sadly, it didn't helped. |
They didn't print either 😞 I will cut a testing release using |
@lordgreg @adailtonribeiro Please try this testing release using
|
@dwieeb Unfortunately it didn't solve the issue for me Also, I ran |
@adailtonribeiro Yeah... your computer doesn't appear to give the Ionic CLI time to shutdown and clean up its resources. This debug line should print if the shutdown is handled gracefully:
Is your terminal sending |
@adailtonribeiro Very strange, but my Windows machine does NOT work with I also don't see the debug logs I was expecting with Ctrl+C, but I DO see them with Ctrl+Break (read more: https://docs.microsoft.com/en-us/windows/console/ctrl-c-and-ctrl-break-signals) Windows is tough... |
@adailtonribeiro Sorry for the tag spam. One more thing to try: on 4.0.3, try running this instead:
|
I tried it using "Command Prompt" and "PowerShell" and in both cases didn't work I couldn't try Ctrl+Break because I have a Dell laptop which doesn't have the Break/Pause key Using the
|
Good morning @dwieeb and others :) I've updated BOTH, global and local ionic to your
Hey! No port left behind! I think you've did it @dwieeb 🚀 This issue is now (as it seems) fixed on Mac! (I cannot say the same with @adailtonribeiro is having). I will, however, also try to update my Windows machine with latest version and report the status. |
Got the same problem and it's now keeping me from coding anything since I can't even kill it manually in the task manager, it doesnt appear everytime in the list but still running in background, don't know where ! While thoses nodes are running, I get a random different result for each serve, without modifying anything in the code. So we're saying Ionic is currently full K.O. or is there any turn around, something ? |
@adailtonribeiro I see. It seems the issue is related to what a dependency is doing with process events and signals. @lordgreg Awesome. I believe Please follow #3481 for the fix. It will be a combination of using |
@adailtonribeiro Is this still broken for you in 4.0.5? |
@dwieeb yes, it was fixed in 4.0.4 but sadly it's broken again in 4.0.5 |
@adailtonribeiro The issue is kind of an architecture problem. I hopefully addressed it in #3500 I tested on my Windows machine and it seems to work, but if you have a moment please try:
|
@dwieeb I tested on my machine and it's working for me too |
Hey together, I know this issue is old, but I got the exact problem with ionic -v 5.4.16 For me, even when I use I use Windows 10 Home Version (10.0.19042 Build 19042)
Does someone has an idea? Got the problem reintroduced in a newer version? |
Description:
Using
ionic serve --port=8101
and then breaking it (CTRL+C) won't close the connection.Steps to Reproduce:
ionic serve --port=8101
ionic serve --port=8101
ps -ef | grep ionic
My
ionic info
:The text was updated successfully, but these errors were encountered: