Should not be able to slide beyond last slide

[henrysxie]

In v1.0.0-beta.5b 'barium-bobcat', I think there is a bug where I'm able to slide beyond the last slide, at which point I'm unable to slide back.

I'm using ng-repeat with an array variable that is resolved via ng-resource. After it's resolved, I call $ionicSlideBoxDelegate.update();

This was also broken for me in the earlier build, Nightly 2081.

[henrysxie]

I think I found the issue:

var isPastBounds =
      !index && delta.x > 0 |                    // if first slide and slide amt is greater than 0
      index == slides.length - 1 && delta.x < 0; // or if last slide and slide amt is less than 0

Note that there is a missing | in the OR logic. This is lines 7106-7108 in ionic.js, in beta.5b.

[ashconnell]

Just thought I would point out I am having the same issue in beta 5b, which wasn't happening in beta 4.

With a basic ion-slide-box and a few ion-slide's hard coded, i am able to swipe back from the first slide (swipe as far as you can from left to right) and let go. A blank slide comes into place and the pager thinks its on the last slide. From then on, all sorts of crazy things happen and it really has no idea which slide it is on, and which slide to display.

I don't currently have time to debug and find out why, but have added to my list of things to look into in the near future if the issues persists.

[ajoslin]

Will fix Monday, thanks.

This was a dumb mistake due to me fixing a JSHint error and making a typo.

And unfortunately, ionSlideBox is one of our 'legacy code' components. It's very untestable and has no unit tests.

We will amending this problem soon.

[ajoslin]

Fixed via ec5a276, can you test out the nightly build in your app and let me know?

[fengshuo]

I am using the v1.0.0-beta.6-nightly-2269 version, still having the bug as Deminetix described.

[fengshuo]

turns out I need to update the whole lib folder with beta.6 to make it work. (I was just updating the js file before)

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.