Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-tabs tabsPlacement top looking bad on iPhone X #13270

Closed
joelmarquez90 opened this issue Oct 28, 2017 · 4 comments · May be fixed by ionic-team/ionic-v1#364
Closed

ion-tabs tabsPlacement top looking bad on iPhone X #13270

joelmarquez90 opened this issue Oct 28, 2017 · 4 comments · May be fixed by ionic-team/ionic-v1#364

Comments

@joelmarquez90
Copy link

Ionic version: (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x] 3.x
[ ] 4.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request

Please do not submit support requests or "How to" questions here. Instead, please use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/

Current behavior:

On the iPhone X simulator, ion-tabs with top tabs placement looks like this:

simulator screen shot - iphone x - 2017-10-28 at 14 14 31

Note that the tabs height it's wrong.

Expected behavior:

It should look like this (iPhone 8):

simulator screen shot - iphone 8 - 2017-10-28 at 14 19 17

Steps to reproduce:

Related code:

This is the html of that page:

<ion-header>
  <ion-navbar color="primary">
    <button ion-button menuToggle>
      <ion-icon name="menu"></ion-icon>
    </button>
    <ion-title>Lavados</ion-title>
  </ion-navbar>

</ion-header>

<ion-tabs #tabs tabsPlacement="top" tabsHighlight=true>
  <ion-tab [root]="upcomingBookings" tabTitle="Próximos"></ion-tab>
  <ion-tab [root]="pastBookings" tabTitle="Finalizados"></ion-tab>
</ion-tabs>

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):

cli packages: (/Users/joel/workspace/glou/Glou/node_modules)

    @ionic/cli-utils  : 1.15.2
    ionic (Ionic CLI) : 3.15.2

global packages:

    cordova (Cordova CLI) : 7.0.1 

local packages:

    @ionic/app-scripts : 1.3.7
    Cordova Platforms  : android 6.2.3 ios 4.5.0
    Ionic Framework    : ionic-angular 3.7.1

System:

    Android SDK Tools : 25.2.5
    ios-deploy        : 1.9.1 
    ios-sim           : 6.0.0 
    Node              : v6.11.3
    npm               : 2.15.12 
    OS                : macOS Sierra
    Xcode             : Xcode 9.0 Build version 9A235 

Environment Variables:

    ANDROID_HOME : /usr/local/opt/android-sdk

Misc:

    backend : legacy
@Sampath-Lokuge
Copy link

Oh.. You're using very old app-scripts and also update your project to latest Ionic 3.8.0. It has a lot of iOS fixes.

https://github.com/ionic-team/ionic/releases/tag/v3.8.0

@joelmarquez90
Copy link
Author

@Sampath-Lokuge still happening, now with the latest tools:

cli packages: (/Users/joel/workspace/glou/Glou/node_modules)

    @ionic/cli-utils  : 1.15.2
    ionic (Ionic CLI) : 3.15.2

global packages:

    cordova (Cordova CLI) : 7.0.1 

local packages:

    @ionic/app-scripts : 3.0.1
    Cordova Platforms  : android 6.2.3 ios 4.5.0
    Ionic Framework    : ionic-angular 3.8.0

System:

    Android SDK Tools : 25.2.5
    ios-deploy        : 1.9.1 
    ios-sim           : 6.0.0 
    Node              : v6.11.3
    npm               : 2.15.12 
    OS                : macOS Sierra
    Xcode             : Xcode 9.0 Build version 9A235 

Environment Variables:

    ANDROID_HOME : /usr/local/opt/android-sdk

Misc:

    backend : legacy

@theHellyar
Copy link

theHellyar commented Nov 6, 2017

With latest scripts and 3.8.0 it is even worse....
tabsPlacement="top" when set to bottom works fine...
See the tabs at top and the faint pixels of the text for those tabs....

for a quick bandaid this works:
.ios { .tabs { .tabbar { margin-top:25px; padding-bottom: 0px; } } }

screen shot 2017-11-06 at 10 04 34 am

israelrios added a commit to israelrios/ionic-v1 that referenced this issue Feb 2, 2018
Tabs on top was broken on iPhone X.
Navbar with input was broken on iPhone X.

Fixes ionic-team/ionic-framework#13270.
israelrios added a commit to israelrios/ionic-v1 that referenced this issue Feb 2, 2018
Tabs on top was broken on iPhone X.
Navbar with input was broken on iPhone X.

Fixes ionic-team/ionic-framework#13270.
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 6, 2018

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

Thank you for using Ionic!

@ionitron-bot ionitron-bot bot closed this as completed Nov 6, 2018
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants