Skip to content

Commit

Permalink
fix(slides): make slide method parameters optional
Browse files Browse the repository at this point in the history
references #5508
  • Loading branch information
brandyscarney committed May 4, 2016
1 parent ab82d53 commit f355087
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions ionic/components/slides/slides.ts
Original file line number Diff line number Diff line change
Expand Up @@ -787,7 +787,7 @@ export class Slides extends Ion {
* @param {number} speed Transition duration (in ms). Optional.
* @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true.
*/
slideTo(index: number, speed: number, runCallbacks: boolean) {
slideTo(index: number, speed?: number, runCallbacks?: boolean) {
this.slider.slideTo(index, speed, runCallbacks);
}

Expand All @@ -797,7 +797,7 @@ export class Slides extends Ion {
* @param {number} speed Transition duration (in ms). Optional.
* @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true.
*/
slideNext(speed: number, runCallbacks: boolean) {
slideNext(speed?: number, runCallbacks?: boolean) {
this.slider.slideNext(runCallbacks, speed);
}

Expand All @@ -807,7 +807,7 @@ export class Slides extends Ion {
* @param {number} speed Transition duration (in ms). Optional.
* @param {boolean} runCallbacks Whether or not to emit the `willChange`/`didChange` events. Optional. Default true.
*/
slidePrev(speed: number, runCallbacks: boolean) {
slidePrev(speed?: number, runCallbacks?: boolean) {
this.slider.slidePrev(runCallbacks, speed);
}

Expand Down
2 changes: 1 addition & 1 deletion ionic/components/slides/test/controller/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,5 @@ class MyPage {
template: `<ion-nav [root]="root"></ion-nav>`
})
class E2EApp {
root: Page = MyPage;
root: any = MyPage;
}

0 comments on commit f355087

Please sign in to comment.