Skip to content

Commit

Permalink
docs(moda): updaing the docs to reflect the proper modal.hidden event.
Browse files Browse the repository at this point in the history
…Closes #1493
  • Loading branch information
17NuF432QCV2vF4fdqYPYMdCuK9jHVDSNG authored and perrygovier committed May 28, 2014
1 parent 1989785 commit ed797eb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion js/angular/directive/item.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
var ITEM_TPL_CONTENT_ANCHOR =
'<a class="item-content" ng-href="{{$href()}}"></a>';
'<a class="item-content" ng-href="{{$href()}}" target="{{$target}}></a>';

This comment has been minimized.

Copy link
@mlynch

mlynch Jun 2, 2014

Contributor

Hey @perrygovier was this line intentional, or did it come along with their PR? It broke list items, but I'm pushing a quick fix for it.

This comment has been minimized.

Copy link
@mlynch

mlynch Jun 2, 2014

Contributor

I reverted all the changes in this file. They also don't make any sense AFAICT

var ITEM_TPL_CONTENT =
'<div class="item-content"></div>';
/**
Expand Down Expand Up @@ -58,6 +58,7 @@ function($animate, $compile) {
$scope.$href = function() {
return $attrs.href || $attrs.ngHref;
};
$scope.$target = $attrs.href || '_self';
};
}
};
Expand Down

1 comment on commit ed797eb

@perrygovier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it was a typo. The PR was regarding implementing targets on <ion-item>'s

Please sign in to comment.