-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
docs(moda): updaing the docs to reflect the proper modal.hidden event. …
…Closes #1493
- Loading branch information
1 parent
1989785
commit ed797eb
Showing
1 changed file
with
2 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
var ITEM_TPL_CONTENT_ANCHOR = | ||
'<a class="item-content" ng-href="{{$href()}}"></a>'; | ||
'<a class="item-content" ng-href="{{$href()}}" target="{{$target}}></a>'; | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
mlynch
Contributor
|
||
var ITEM_TPL_CONTENT = | ||
'<div class="item-content"></div>'; | ||
/** | ||
|
@@ -58,6 +58,7 @@ function($animate, $compile) { | |
$scope.$href = function() { | ||
return $attrs.href || $attrs.ngHref; | ||
}; | ||
$scope.$target = $attrs.href || '_self'; | ||
}; | ||
} | ||
}; | ||
|
1 comment
on commit ed797eb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it was a typo. The PR was regarding implementing targets on <ion-item>
's
Hey @perrygovier was this line intentional, or did it come along with their PR? It broke list items, but I'm pushing a quick fix for it.