fix(select): floating label

fixes #12068
ionic-team · Jun 19, 2017 · e3a8d27 · e3a8d27
1 parent d8b65da
commit e3a8d27
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/components/item/test/inputs/pages/root-page/root-page.html b/src/components/item/test/inputs/pages/root-page/root-page.html
@@ -20,13 +20,14 @@
     </button>
 
     <ion-item>
-      <ion-label>DateTime</ion-label>
+      <ion-label floating>DateTime</ion-label>
       <ion-datetime [(ngModel)]="datetime" min="1994-03-14" max="2017-12-09" displayFormat="MM/DD/YYYY" required [disabled]='disabled'></ion-datetime>
     </ion-item>
 
     <ion-item>
-      <ion-label>Select</ion-label>
+      <ion-label floating>Select</ion-label>
       <ion-select [(ngModel)]="select" [disabled]='strDisabled()'>
+        <ion-option value="">No Game Console</ion-option>
         <ion-option value="nes">NES</ion-option>
         <ion-option value="n64">Nintendo64</ion-option>
         <ion-option value="ps">PlayStation</ion-option>
@@ -42,7 +43,7 @@
     </ion-item>
 
     <ion-item>
-      <ion-label>Input (text)</ion-label>
+      <ion-label floating>Input (text)</ion-label>
       <ion-input [(ngModel)]="text" [disabled]='disabled'></ion-input>
     </ion-item>
 

diff --git a/src/components/select/select.ts b/src/components/select/select.ts
@@ -496,6 +496,7 @@ export class Select extends BaseInput<any> implements OnDestroy {
     }
 
     this._text = this._texts.join(', ');
+    super._inputUpdated();
   }
 
 }
diff --git a/src/components/select/test/single-value/pages/page-one/page-one.html b/src/components/select/test/single-value/pages/page-one/page-one.html
@@ -10,7 +10,7 @@
 <ion-content class="outer-content">
 
   <ion-item>
-    <ion-label>Gender</ion-label>
+    <ion-label stacked>Gender</ion-label>
     <ion-select [(ngModel)]="gender" class="e2eSelectGender">
       <ion-option value="f">Female</ion-option>
       <ion-option value="m">Male</ion-option>
@@ -39,7 +39,7 @@
   </ion-item>
 
   <ion-item>
-    <ion-label>Operating System</ion-label>
+    <ion-label floating>Operating System</ion-label>
     <ion-select [(ngModel)]="os" interface="alert" submitText="Okay" cancelText="Nah">
       <ion-option value="dos">DOS</ion-option>
       <ion-option value="lunix">Linux</ion-option>
-Original file line number
+Diff line change
@@ Expand Up @@
         }
         this._text = this._texts.join(', ');
+        super._inputUpdated();
       }
     }