Skip to content

Commit

Permalink
ci(lint): ensure linted results are pushed for build to pass (#25196)
Browse files Browse the repository at this point in the history
  • Loading branch information
liamdebeasi authored Apr 26, 2022
1 parent 70d2784 commit b259ca6
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 14 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/actions/test-core-lint/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,10 @@ runs:
run: npm run lint
shell: bash
working-directory: ./core
# Lint changes should be pushed
# to the branch before the branch
# is merge eligible.
- name: Check Lint Results
run: git diff --exit-code
shell: bash
working-directory: ./core
1 change: 0 additions & 1 deletion core/src/components/footer/footer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { Component, Element, Host, Prop, h } from '@stencil/core';
import { getIonMode } from '../../global/ionic-global';
import { findIonContent, getScrollElement, printIonContentErrorMsg } from '../../utils/content';


import { handleFooterFade } from './footer.utils';

/**
Expand Down
1 change: 0 additions & 1 deletion core/src/components/infinite-scroll/infinite-scroll.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { Component, Element, Event, Host, Method, Prop, State, Watch, h, readTas
import { getIonMode } from '../../global/ionic-global';
import { findClosestIonContent, getScrollElement, printIonContentErrorMsg } from '../../utils/content';


@Component({
tag: 'ion-infinite-scroll',
styleUrl: 'infinite-scroll.scss',
Expand Down
6 changes: 3 additions & 3 deletions core/src/components/modal/modal-interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ export interface ModalOptions<T extends ComponentRef = ComponentRef> {
delegate?: FrameworkDelegate;
animated?: boolean;
/**
* If `true`, the modal can be swiped to dismiss. Only applies in iOS mode.
* @deprecated - To prevent modals from dismissing, use canDismiss instead.
*/
* If `true`, the modal can be swiped to dismiss. Only applies in iOS mode.
* @deprecated - To prevent modals from dismissing, use canDismiss instead.
*/
swipeToClose?: boolean;
canDismiss?: boolean | (() => Promise<boolean>);

Expand Down
1 change: 0 additions & 1 deletion core/src/components/refresher/refresher.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type { ComponentInterface, EventEmitter } from '@stencil/core';
import { Component, Element, Event, Host, Method, Prop, State, Watch, h, readTask, writeTask } from '@stencil/core';


import { getIonMode } from '../../global/ionic-global';
import type { Animation, Gesture, GestureDetail, RefresherEventDetail } from '../../interface';
import { getTimeGivenProgression } from '../../utils/animation/cubic-bezier';
Expand Down
1 change: 0 additions & 1 deletion core/src/components/reorder-group/reorder-group.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type { ComponentInterface, EventEmitter } from '@stencil/core';
import { Component, Element, Event, Host, Method, Prop, State, Watch, h } from '@stencil/core';


import { getIonMode } from '../../global/ionic-global';
import type { Gesture, GestureDetail, ItemReorderEventDetail } from '../../interface';
import { findClosestIonContent, getScrollElement } from '../../utils/content';
Expand Down
8 changes: 1 addition & 7 deletions core/src/utils/test/playwright/playwright-page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,7 @@ import type {
import { test as base } from '@playwright/test';

import { initPageEvents } from './page/event-spy';
import {
getSnapshotSettings,
goto as goToPage,
setIonViewport,
spyOnEvent,
waitForChanges,
} from './page/utils';
import { getSnapshotSettings, goto as goToPage, setIonViewport, spyOnEvent, waitForChanges } from './page/utils';
import type { E2EPage } from './playwright-declarations';

type CustomTestArgs = PlaywrightTestArgs &
Expand Down

0 comments on commit b259ca6

Please sign in to comment.