perf(menu): avoiding change detection when unneeded

ionic-team · Nov 2, 2016 · 479d500 · 479d500
1 parent c76d15d
commit 479d500
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/components/menu/menu-gestures.ts b/src/components/menu/menu-gestures.ts
@@ -21,6 +21,7 @@ export class MenuContentGesture extends SlideEdgeGesture {
       threshold: 0,
       maxEdgeStart: menu.maxEdgeStart || 50,
       maxAngle: 40,
+      zone: false,
       debouncer: new NativeRafDebouncer(),
       gesture: gestureCtrl.create('menu-swipe', {
         priority: GesturePriority.MenuSwipe,
@@ -58,7 +59,6 @@ export class MenuContentGesture extends SlideEdgeGesture {
       'z', z,
       'stepValue', stepValue);
 
-    ev.preventDefault();
     this.menu.swipeProgress(stepValue);
   }
 

diff --git a/src/components/menu/menu.ts b/src/components/menu/menu.ts
@@ -450,7 +450,11 @@ export class Menu {
       return;
     }
     this._getType().setProgessStep(stepValue);
-    this.ionDrag.emit(stepValue);
+
+    let ionDrag = this.ionDrag;
+    if (ionDrag.observers.length > 0) {
+      this._zone.run(ionDrag.emit.bind(ionDrag, stepValue));
+    }
   }
 
   /**