Skip to content

Commit

Permalink
fix(refresher): make arrow spin correctly
Browse files Browse the repository at this point in the history
Closes #1319
  • Loading branch information
ajoslin committed May 9, 2014
1 parent 5be42bc commit 2ec0173
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion js/angular/directive/refresher.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ IonicModule
'<div class="scroll-refresher">' +
'<div class="ionic-refresher-content" ' +
'ng-class="{\'ionic-refresher-with-text\': pullingText || refreshingText}">' +
'<i class="icon {{pullingIcon}} icon-pulling"></i>' +
'<div class="icon-pulling">' +
'<i class="icon {{pullingIcon}}"></i>' +
'</div>' +
'<div class="text-pulling" ng-bind-html="pullingText"></div>' +
'<i class="icon {{refreshingIcon}} icon-refreshing"></i>' +
'<div class="text-refreshing" ng-bind-html="refreshingText"></div>' +
Expand Down
6 changes: 3 additions & 3 deletions test/unit/angular/directive/refresher.unit.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@ describe('ionRefresher directive', function() {

it('should have default pullingIcon', function() {
var el = setup();
expect(el[0].querySelector('.icon.icon-pulling.ion-arrow-down-c')).toBeTruthy();
expect(el[0].querySelector('.icon-pulling .ion-arrow-down-c')).toBeTruthy();
});
it('should allow custom pullingIcon', function() {
var el = setup('pulling-icon="super-icon"');
expect(el[0].querySelector('.icon.icon-pulling.ion-arrow-down-c')).toBeFalsy();
expect(el[0].querySelector('.icon.icon-pulling.super-icon')).toBeTruthy();
expect(el[0].querySelector('.icon-pulling .ion-arrow-down-c')).toBeFalsy();
expect(el[0].querySelector('.icon-pulling .super-icon')).toBeTruthy();
});

it('should have default refreshingIcon', function() {
Expand Down

0 comments on commit 2ec0173

Please sign in to comment.