Skip to content

Commit

Permalink
Improve docs (#8310)
Browse files Browse the repository at this point in the history
* Added explanation for typescript private to public change

* Added explanation for typescript private to public change
  • Loading branch information
yannbf authored and danbucholtz committed Oct 1, 2016
1 parent e86cb14 commit 1d6af90
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,8 @@ Note: For details on NgModules you can read the Angular docs on them [here](http

10. Change any uses of the `private` TypeScript keyword to `public` ONLY for component variables that are needed in the associated template.

Note: For details as to why this change has to be made, there is a discussion about it [here](https://forum.ionicframework.com/t/rc0-typescript-private-vs-public-keyword/64863/4?u=mhartington).

11. Change `<button>` to `<button ion-button>` according to [these instructions](#new-behavior-of-button).

12. Pass colors to the `color` attribute : `<button primary>` changes to `<button color="primary">`. See [component colors](#component-colors) above.
Expand Down Expand Up @@ -443,6 +445,8 @@ page-selector-you-added {

31. Change any uses of the `private` TypeScript keyword to `public` ONLY for component variables that are needed in the associated template.

Note: For details as to why this change has to be made, there is a discussion about it [here](https://forum.ionicframework.com/t/rc0-typescript-private-vs-public-keyword/64863/4?u=mhartington).

32. Change any Ionic buttons from `<button>` to `<button ion-button>`. [See New Behavior of Button](#new-behavior-of-button).

33. Pass colors to the `color` attribute: `<button primary>` changes to `<button color="primary">`.
Expand Down

0 comments on commit 1d6af90

Please sign in to comment.