-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: show how to account for this #3333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Dec 18, 2023
liamdebeasi
requested review from
sean-perkins
and removed request for
a team
December 18, 2023 20:23
thetaPC
requested changes
Dec 18, 2023
Co-authored-by: Maria Hutt <[email protected]>
thetaPC
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
averyjohnston
approved these changes
Dec 19, 2023
Co-authored-by: Amanda Johnston <[email protected]>
github-merge-queue bot
pushed a commit
to ionic-team/ionic-framework
that referenced
this pull request
Dec 19, 2023
Issue number: N/A --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> In #28694 there was some confusion around how to access `this` inside of a callback function passed to a property on Ionic components. The root issue was due to how the `this` context is determined with developers being responsible for setting the appropriate `this` context. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - While this isn't an Ionic bug, I think it's worth calling out this behavior so developers are aware of how to account for it. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Note: The link in the docs will not work until ionic-team/ionic-docs#3333 is merged. --------- Co-authored-by: Amanda Johnston <[email protected]>
rdlabo
added a commit
that referenced
this pull request
Feb 28, 2024
* chore(support): update support table (#3164) * chore(support): update support table * update versioned support tables * fix(deps): update dependency @types/node to v18.18.1 (#3163) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs: add docs for dynamic font scaling (#3111) * docs(angular): add standalone documentation (#3115) * docs(dynamic-font): fix font family name (#3149) * docs: add modules architecture usage (#3151) * docs(angular): add angular standalone syntax to non-playground examples (#3116) * fix(angular): standalone guide formatting (#3152) * docs(angular): include add diff sign (#3157) * docs(toast): add playground for positionAnchor (#3158) * chore: resolve cspell errors (#3165) * chore: resolve cspell errors * chore: ignore all node_modules folders * chore: adjust sorting * docs(select): keyboard navigation (#3156) * chore(deps): update dependency vue-tsc to v1.8.14 (#3159) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency web-vitals to v3 (#3142) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: team is requested for review for renovatebot prs (#3168) * fix typo * chore * chore * fix(deps): update dependency vue-router to v4.2.5 (#3147) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @types/react to v18.2.22 (#3141) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue-tsc to v1.8.15 (#3170) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @types/node to v18.18.3 (#3171) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @vitejs/plugin-vue to v4.4.0 (#3172) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update ionic to v7.4.3 (#3178) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update react monorepo (#3179) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency web-vitals to v3.5.0 (#3173) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: team is requested for review for renovatebot lockfile prs (#3180) * chore(deps): update dependency vite to v4.4.11 (#3177) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(playground): persist framework and mode selection (#3169) * fix(deps): update dependency @types/node to v18.18.4 (#3182) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue-tsc to v1.8.16 (#3181) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(playground): wait until playground is in view before loading stored framework/mode (#3185) * docs(menu): clarify multiple side menu behavior (#3186) * docs(angular): document standalone routing usage (#3167) * docs(many): remove legacy form control syntax from v7 playgrounds (#3140) * docs(angular): add a section to standalone migration for migrating components (#3176) * chore(deps): update dependency vue-tsc to v1.8.18 (#3188) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(jp): re-add files for removed playgrounds (#3189) * chore: remove unused file * fix(): fix cspell check * translate * chore * chore: run lint * feat(keyboard): replace Codepens with playgrounds using modern syntax (#3192) * fix(deps): update dependency @types/react-dom to v18.2.11 (#3183) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update codeowners (#3187) * fix(deps): update ionic to v7.5.0 (#3197) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update react monorepo (#3196) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @types/node to v18.18.5 (#3195) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue-tsc to v1.8.19 (#3194) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs: clarify IonicSafeString usage (#3198) I've seen some confusion in threads such as ionic-team/ionic-framework#28365 as to when to use IonicSafeString, so I wanted to clarify this on the docs. * docs(input, textarea): fix specificity issues with theming playgrounds (#3199) * fix(backdrop): make backdrop visible in basic playground (#3200) Co-authored-by: Brandy Carney <[email protected]> * chore(deps): update dependency vite to v4.5.0 (#3206) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(react): writing tests with testing-library (#2861) * fix(deps): update dependency vue to v3.3.5 (#3204) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @types/node to v18.18.6 (#3202) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update react monorepo (#3205) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update ionic to v7.5.1 (#3203) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(fab): remove unused component from playground (#3207) * fix(deps): update dependency @types/react to v18.2.31 (#3209) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20 (#3211) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue-tsc to v1.8.20 (#3212) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(api): get current readme * translate * fix(lint): ignore src/translate * chore(deps): update ionic to v7.5.2 (#3216) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.8.9 (#3214) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue-tsc to v1.8.22 (#3213) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: add framework team as code owners (#3218) * fix(textarea): autogrow playground can scroll to the top of contents (#3219) * docs: change comments for pwa-elements defineCustomElements (#3191) * chore(docusaurus): update to latest (#3014) * fix(deps): update dependency vue to v3.3.6 (#3210) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @types/react to v18.2.33 (#3215) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue to v3.3.7 (#3221) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(angular): clarify addIcons usage (#3222) * docs(angular): add note on migration utility (#3223) * docs(react): link to vitest docs (#3225) * docs(react): link to vitest docs * docs: add vitest to introduction section * chore: regenerate cli.json (#3193) * chore(deps): update dependency @types/node to v20.8.10 (#3228) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ionic to v7.5.3 (#3230) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(renovate): use chore subject line for prs (#3234) * chore(renovate): update config to ignore typescript updates in react v6 (#3231) * docs(toggle): increase height of the label placement demo (#3238) * docs(react): v7 playgrounds use vite (#3236) * docs(radio): playground for compareWith (#3237) * docs(reorder): assign stable identity to loop items (#3239) * docs(angular): vscode settings for standalone usages (#3233) * fix(deps): update dependency @types/react to v18.2.34 (#3229) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(alert): update content in playground examples (#3235) * fix(playground): support angular 17 template (#3242) * chore(deps): update dependency vue to v3.3.8 (#3240) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(react): v6 playgrounds use vite (#3246) * chore(deps): update dependency @types/node to v20.9.0 (#3245) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ionic to v7.5.4 (#3244) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @vitejs/plugin-vue to v4.4.1 (#3243) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(renovate): revert typescript ignore rule (#3248) This reverts commit 94aba0a. * chore(deps): update react monorepo (#3241) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(support): note angular 17 support (#3249) * chore(renovate): match explicitly the react-router and react-router-dom (#3257) * chore(ci): run workflow against node v20 (#3259) * chore(deps): update ionic to v7.5.5 (#3253) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.9.1 (#3252) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @vitejs/plugin-react to v4.2.0 (#3254) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @vitejs/plugin-vue to v4.5.0 (#3255) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typescript to v5.3.2 (#3261) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update react monorepo (#3262) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(react): update live reload to fix order (#3265) Set return order of usePhotoGallery the same as expected in Tab2 * docs(toast): add swipeGesture playground (#3247) * chore(deps): update dependency @types/react-dom to v18.2.17 (#3267) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue to v3.3.9 (#3270) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(autofocus): playground examples for setFocus (#3258) --------- Co-authored-by: Shawn Taylor <[email protected]> Co-authored-by: Liam DeBeasi <[email protected]> * chore(deps): update dependency @types/node to v20.10.0 (#3269) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore * translate * chore * chore: update renovate to update react (#3273) * fix(): copy package.json from repository * fix(color-generator): contrast color calculation (#3274) * fix(color-generator): contrast color calculation * refactor: apply types and code style * chore(deps): update ionic to v7.5.6 (#3268) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(color-generator): add missing dark color (#3279) * chore(deps): update dependency @types/react to v18.2.39 (#3276) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(input, textarea, select): add section for start and end slots (#3271) * chore(google-tag-manager): switch to Docusaurus preset (#3280) * chore(deps): update dependency @vitejs/plugin-vue to v4.5.1 (#3286) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.10.1 (#3283) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ionic to v7.5.7 (#3285) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(color-generator): consistently format value as hex color (#3282) * chore(deps): update dependency @angular/platform-browser-dynamic to v17.0.4 (#3275) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue-tsc to v1.8.24 (#3284) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/react to v18.2.40 (#3289) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.10.2 (#3288) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(color-generator): generate correct secondary color (#3290) * fix(playground): tabs stackblitz example loads in Safari (#3287) * chore(select): remove unneeded patch from start/end slots demo (#3295) * chore(deps): update dependency @types/react to v18.2.41 (#3294) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vite to v4.5.1 [security] (#3293) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.10.3 (#3297) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/react to v18.2.42 (#3299) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @vitejs/plugin-react to v4.2.1 (#3300) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @vitejs/plugin-vue to v4.5.2 (#3308) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.10.4 (#3307) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(angular): note jest transformIgnorePatterns for es modules (#3298) * chore(deps): update dependency typescript to v5.3.3 (#3309) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ionic to v7.6.0 (#3311) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(item): clarify usage for text wrapping (#3314) * docs(layout): fix path from dynamic font to typography (#3312) * chore(renovate): package vite with related plugins (#3266) * chore(deps): update dependency @types/react to v18.2.43 (#3317) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vite to v5 (#3318) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vite to v5 (#3319) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(app-store): update release build to include capacitor steps (#3324) Co-authored-by: Matthew Harris <[email protected]> * docs(radio): fix radio demo (#3326) * chore(deps): update dependency @types/react to v18.2.45 (#3329) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ionic to v7.6.1 (#3332) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vite to v5.0.9 (#3331) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/react-dom to v18.2.18 (#3336) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vite to v5.0.10 (#3337) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs: show how to account for this (#3333) * chore * docs(popover): warn about popover attribute on v5 (#3339) * docs(support): revise wording (#3341) * chore(deps): update dependency @types/node to v20.10.5 (#3343) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(refresher): add rubber band effect for virtual scroll (#3345) * chore(deps): update dependency vite to v5.0.9 (#3330) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ionic to v7.6.2 (#3348) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vite to v5.0.10 (#3349) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @vitejs/plugin-vue to v5 (#3350) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue to v3.3.10 (#3301) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue-tsc to v1.8.25 (#3310) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue to v3.4.0 (#3355) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @angular/platform-browser-dynamic to v17.0.8 (#3351) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @vitejs/plugin-vue to v5.0.1 (#3357) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue to v3.4.3 (#3361) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue-tsc to v1.8.27 (#3353) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency clsx to v2.1.0 (#3358) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/react to v18.2.46 (#3352) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency web-vitals to v3.5.1 (#3354) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(many): remove implications that we support desktop apps (#3366) * docs(hbb): document close watcher support (#3364) * chore(deps): update dependency @types/node to v20.10.6 (#3356) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(desktop): remove desktop app deployment docs (#3365) * chore(deps): update dependency vue to v3.4.5 (#3371) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(playground): use correct usage target or mode, when limited (#3367) * chore(deps): update dependency vite to v5.0.11 (#3375) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue to v3.4.6 (#3382) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue to v3.4.10 (#3385) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(docusaurus): upgrade to v3 (#3322) * chore(playgrounds): update demos to use latest major version (#3388) * chore(deps): update dependency vue to v3.4.11 (#3387) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(label): clarify usage for text wrapping (#3386) * chore(deps): update dependency @vitejs/plugin-vue to v5.0.2 (#3360) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ionic to v7.6.3 (#3372) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/react to v18.2.47 (#3376) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.10.7 (#3379) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue to v3.4.13 (#3389) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.11.0 (#3392) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ionic to v7.6.4 (#3391) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.11.1 (#3393) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/react to v18.2.48 (#3394) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue to v3.4.14 (#3397) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.11.3 (#3396) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vue to v3.4.15 (#3400) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vite to v5.0.12 [security] (#3398) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.11.5 (#3399) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update ionic to v7.6.5 (#3401) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency vite to v5.0.12 [security] (#3403) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @vitejs/plugin-vue to v5.0.3 (#3390) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(input): update `Maskito` documentation (according to the latest major release `2.0.0`) (#3402) * chore(deps): update ionic to v7.6.6 (#3411) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/node to v20.11.6 (#3409) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(node): upgrade to v20 (#3404) * chore(deps): update dependency web-vitals to v3.5.2 (#3410) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(angular): use ngmodules for the first app (#3417) * chore(deps): update dependency @types/node to v20.11.7 (#3414) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(searchbar): streamline usage example with script setup syntax (#3408) * docs(searchbar): streamline usage example with script setup syntax (#3406) * chore(deps): update dependency @angular/platform-browser-dynamic to v17.1.1 (#3423) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @types/react to v18.2.51 (#3425) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * docs(react, vue): update Quickstart page to use modern checkbox syntax (#3415) * chore(deps): update dependency @types/react to v18.2.52 (#3430) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: release notes generation from changelog (#3428) * docs(toast): clarify toasts from overlays (#3432) * chore(deps): update dependency @types/react to v18.2.53 (#3433) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: npm install * fmt * chore(): remove duplication package * translate * fix(): follow ionicframework.com * chore(ci): update node version * fix(): comment-out unused script * chore(): follow package-lock.json * fix(): npm install at root --------- Co-authored-by: Shawn Taylor <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Liam DeBeasi <[email protected]> Co-authored-by: Amanda Johnston <[email protected]> Co-authored-by: Sean Perkins <[email protected]> Co-authored-by: Maria Hutt <[email protected]> Co-authored-by: Brandy Carney <[email protected]> Co-authored-by: jcesarmobile <[email protected]> Co-authored-by: sylvainvdm <[email protected]> Co-authored-by: ptmkenny <[email protected]> Co-authored-by: Matthew Harris <[email protected]> Co-authored-by: Nikita Barsukov <[email protected]> Co-authored-by: Treigh Mawaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ionic-team/ionic-framework#28694 there was some confusion around how to access
this
inside of a callback function passed to a property on Ionic components. The root issue was due to how thethis
context is determined with developers being responsible for setting the appropriatethis
context.The team agreed that it would be good to document this behavior so developers are aware of it. I plan to link to this new section from the relevant component props in a separate PR on the Ionic Framework repo.