docs(datetime): add new css variable for styling picker #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
force-pushed
the
FW-5582
branch
from
d1c2d4b to
0e6b41d
Compare
Merged
2 tasks
brandyscarney
force-pushed
the
FW-5582
branch
from
d045e13 to
074a4b6
Compare
brandyscarney
requested review from
liamdebeasi and
a team
and removed request for
a team
brandyscarney
added a commit
to ionic-team/ionic-framework
that referenced
this pull request
Dec 11, 2023
Issue number: N/A
---------
## What is the current behavior?
Picker has the following CSS variables for styling:
`--wheel-fade-background-rgb` and `--wheel-highlight-background`
These variables make sense when used from `ion-datetime`, but picker
does not need the `wheel` prefix.
## What is the new behavior?
### Datetime
- Adds `--wheel-highlight-border-radius`
- Keeps `--wheel-fade-background-rgb` and `--wheel-highlight-background`
- Assigns these variables to picker's new variables
```scss
ion-picker {
--highlight-background: var(--wheel-highlight-background);
--highlight-border-radius: var(--wheel-highlight-border-radius);
--fade-background-rgb: var(--wheel-fade-background-rgb);
}
```
### Picker
Renames `--wheel-fade-background-rgb` and `--wheel-highlight-background`
and adds another CSS variables to `ion-picker`:
- Renames `--wheel-fade-background-rgb` to `--fade-background-rgb`
- Renames `--wheel-highlight-background` to `--highlight-background`
- Adds `--highlight-border-radius`
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
## Other information
PR to update the [Datetime docs](ionic-team/ionic-docs#3303)
---------
Co-authored-by: ionitron <[email protected]>
liamdebeasi
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Works well on my end.
For some reason the preview isn't using the dev build but it works locally
Make sure you are on the v8 docs not the v7 docs (we default to v7). So the actual preview link would be https://ionic-docs-git-fw-5582-ionic1.vercel.app/docs/v8/api/datetime#wheel-pickers
|
@liamdebeasi That's exactly what I was doing wrong. 🤦♀️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new CSS variable to datetime that was added with ionic-team/ionic-framework#28654
7.5.8-dev.11702320396.1294c304Preview link - https://ionic-docs-git-fw-5582-ionic1.vercel.app/docs/v8/api/datetime#wheel-pickers