Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(datetime): add preferWheel playground #2385

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

Part of ionic-team/ionic-framework#23981

Adds a playground that shows how to use preferWheel

@liamdebeasi liamdebeasi marked this pull request as ready for review June 13, 2022 13:50
@liamdebeasi
Copy link
Contributor Author

liamdebeasi commented Jun 13, 2022

Note: The stackblitz examples load the latest stable version of Ionic, so they will not know how to handle preferWheel. The demo file is hardcoded to use a dev build of Ionic that has the preferWheel feature.

@liamdebeasi liamdebeasi requested review from averyjohnston and sean-perkins and removed request for averyjohnston June 13, 2022 13:51
@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ionic-docs ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 6:14PM (UTC)

Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playground looks good 👍 seeing a live example like this, does make me question if there should be some sort of loading indication in the future, for when rendering the next/previous months & days from the intersection observer hitting the threshold.

@liamdebeasi
Copy link
Contributor Author

FYI I'm going to change the CDN url back to the latest stable version just so I don't forget to do it when we release 6.2

@liamdebeasi liamdebeasi merged commit 34ea348 into feature-6.2 Jun 14, 2022
@liamdebeasi liamdebeasi deleted the 1310-docs branch June 14, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants