-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the '-b' flag is not being respected in v3 #2215
Comments
Right now What do you expect to happen when both flags are supplied? |
since I can always go to the 'lab' using the url '/ionic-lab', I expect passing -b to mean, I explicitly don't want to open the browser because I know which Urls to go to. For example if i already have the browser open with the right url |
Gotcha @sfabriece, I understand 👍 @danbucholtz Can we review this line here: https://github.com/driftyco/ionic-app-scripts/blob/c17e6dfa132039e92c6cc3042a38183ffeb531dc/src/serve.ts#L76 |
@sfabriece Probably won't be fixed for v3 launch, but we'd like to fix this in the future. |
sounds good @dwieeb. Should i close this issue? |
@sfabriece If you don't mind I'll keep it open under the milestone. |
Hi @sfabriece, I finally got around to this. It will be fixed in 3.7 for both Ionic 1 and Ionic Angular. |
awesome @dwieeb |
What version of the CLI are you using? Output of
ionic --version
3.0.0-rc.1
Short description of the problem:
the following command opens the browser.
ionic serve -scb --lab
What behavior are you expecting?
I expect the command to run without a browser tab being opened.
Post the output of
ionic info
below pleaseOther information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
output after running the command.
Starting app-scripts server: --consolelogs --serverlogs --nobrowser --lab --port 8100 --livereload-port 35729 --address 0.0.0.0
The text was updated successfully, but these errors were encountered: