Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the '-b' flag is not being respected in v3 #2215

Closed
sfabriece opened this issue May 4, 2017 · 8 comments
Closed

the '-b' flag is not being respected in v3 #2215

sfabriece opened this issue May 4, 2017 · 8 comments
Milestone

Comments

@sfabriece
Copy link

What version of the CLI are you using? Output of ionic --version

3.0.0-rc.1

Short description of the problem:

the following command opens the browser.

ionic serve -scb --lab

What behavior are you expecting?

I expect the command to run without a browser tab being opened.

Post the output of ionic info below please

global packages:

    @ionic/cli-utils : 1.0.0-rc.1
    Ionic CLI        : 3.0.0-rc.1

local packages:

    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-ionic-angular : 1.0.0-rc.1
    Ionic Framework                 : ionic-angular 3.1.1

System:

    Node       : v7.8.0
    OS         : Windows 10
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

output after running the command.

Starting app-scripts server: --consolelogs --serverlogs --nobrowser --lab --port 8100 --livereload-port 35729 --address 0.0.0.0

@imhoffd
Copy link
Contributor

imhoffd commented May 4, 2017

Right now --lab overrides -b. It doesn't make sense to supply both flags, as --lab is a feature for the launched browser.

What do you expect to happen when both flags are supplied?

@sfabriece
Copy link
Author

sfabriece commented May 5, 2017

since I can always go to the 'lab' using the url '/ionic-lab', I expect passing -b to mean, I explicitly don't want to open the browser because I know which Urls to go to.

For example if i already have the browser open with the right url

@imhoffd
Copy link
Contributor

imhoffd commented May 5, 2017

@imhoffd imhoffd added this to the CLI Future milestone May 5, 2017
@imhoffd
Copy link
Contributor

imhoffd commented May 5, 2017

@sfabriece Probably won't be fixed for v3 launch, but we'd like to fix this in the future.

@sfabriece
Copy link
Author

sounds good @dwieeb. Should i close this issue?

@imhoffd
Copy link
Contributor

imhoffd commented May 6, 2017

@sfabriece If you don't mind I'll keep it open under the milestone.

imhoffd added a commit that referenced this issue Aug 2, 2017
@imhoffd imhoffd modified the milestones: CLI Next, CLI Future Aug 2, 2017
@imhoffd
Copy link
Contributor

imhoffd commented Aug 2, 2017

Hi @sfabriece, I finally got around to this. It will be fixed in 3.7 for both Ionic 1 and Ionic Angular.

@sfabriece
Copy link
Author

awesome @dwieeb

mlynch pushed a commit to ionic-team/ionic-app-scripts that referenced this issue Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants