This repository has been archived by the owner on May 1, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 304
fix(build): fix issue that extends
in ts-config.json
property is …
#851
Closed
alan-agius4
wants to merge
6
commits into
ionic-team:master
from
alan-agius4:feature/fix-ts-config-issues
Closed
fix(build): fix issue that extends
in ts-config.json
property is …
#851
alan-agius4
wants to merge
6
commits into
ionic-team:master
from
alan-agius4:feature/fix-ts-config-issues
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bdw, you be good to enable CircleCI to run on PRs, as well |
@danbucholtz any updates? |
Can you rebase and submit again? At first glance I would think this would be fine. Thanks, |
@danbucholtz, just did :) |
# Conflicts: # src/transpile.ts
@danbucholtz all tests are green and rebased. |
Can you just resubmit this? Github is not letting me merge still. Thanks, |
@danbucholtz, here's the new PR #910 |
Thanks, I'll test and merge tomorrow. Thanks, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
While typescript support
extends
of another tsconfig, a limitation invalidateRequiredFilesExist
method doesn't as it's reading the file usingfs
, rather thangetTsConfig
which is a wrapper of theTypeScript API
,Changes proposed in this pull request:
getTsConfigAsync
methodvalidateRequiredFilesExist
use it rather thanreadFileAsync
for thetsconfig.json
Note: I cannot run Unit Tests
Fixes: #745