Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

fix(build): fix extends in ts-config.json #910

Merged
merged 1 commit into from
Apr 21, 2017

Conversation

alan-agius4
Copy link
Contributor

Short description of what this resolves:

While typescript support extends of another tsconfig, a limitation in validateRequiredFilesExist method doesn't as it's reading the file using fs, rather than getTsConfig which is a wrapper of the TypeScript API,

Changes proposed in this pull request:

  • Impalement getTsConfigAsync method
  • In validateRequiredFilesExist use it rather than readFileAsync for the tsconfig.json

Note: I cannot run Unit Tests

Fixes: #745

@danbucholtz
Copy link
Contributor

@alan-agius4,

Thanks!

Thanks,
Dan

@alan-agius4 alan-agius4 deleted the feature/tsconfig-extends branch April 22, 2017 06:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants