Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(android): consolidate bridge construction #3866

Merged
merged 10 commits into from
Dec 1, 2020
Merged

refactor(android): consolidate bridge construction #3866

merged 10 commits into from
Dec 1, 2020

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Nov 25, 2020 •
edited
Loading

  • the Bridge constructor is a beast that cannot be tamed, so let's deprecate it in favor of a builder class
  • consolidate construction logic in BridgeActivity and BridgeFragment
  • move CordovaWebView into Bridge to hook into bridge lifecycle hooks instead of being a separate thing

@imhoffd imhoffd requested a review from carlpoole November 25, 2020 23:02
@imhoffd imhoffd marked this pull request as draft November 25, 2020 23:03
@imhoffd imhoffd marked this pull request as ready for review November 29, 2020 21:02
@imhoffd imhoffd added this to the 3.0.0 milestone Nov 29, 2020
@imhoffd imhoffd mentioned this pull request Nov 29, 2020
Merged
3 tasks
@imhoffd imhoffd merged commit b417278 into main Dec 1, 2020
@imhoffd imhoffd deleted the refactor-bridge branch December 1, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlpoole carlpoole carlpoole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@imhoffd @carlpoole