chore: remove App plugin #3676
Merged
chore: remove App plugin #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
force-pushed
the
remove-app
branch
from
a7ab924 to
4b3f355
Compare
imhoffd
reviewed
Oct 16, 2020
imhoffd
approved these changes
Oct 16, 2020
|
Would it make sense to allow multiple listeners to these events, instead of just one? |
I wondered that too. I think it makes sense to allow for it |
carlpoole
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since on Android the App plugin was very coupled with the bridge I've created a new App class (that is not a plugin) to host that functionality and the App plugin will use it as an intermediary, i.e subscribe to its events.