Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): move splash screen trigger before the webview render to prevent flicker #3596

Closed
wants to merge 5 commits into from
Closed

fix(android): move splash screen trigger before the webview render to prevent flicker #3596

wants to merge 5 commits into from

Conversation

carlpoole
Copy link
Member

This seems to fix the following flickering issue

#3368

@carlpoole carlpoole changed the title Move splash screen show to happen before the webview renders, to prevent flicker fix(android): move splash screen trigger before the webview render to prevent flicker Sep 22, 2020
@imhoffd
Copy link
Contributor

imhoffd commented Sep 23, 2020

LGTM, but please recreate on the 2.x branch.

@carlpoole carlpoole mentioned this pull request Sep 23, 2020
Merged
@imhoffd
Copy link
Contributor

imhoffd commented Sep 23, 2020

This will make it in when we merge 2.x into main.

@imhoffd imhoffd closed this Sep 23, 2020
@imhoffd imhoffd deleted the splash-flicker branch September 23, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile left review comments

@imhoffd imhoffd Awaiting requested review from imhoffd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlpoole @imhoffd @jcesarmobile