-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin Import updates #3305
Plugin Import updates #3305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass looks good, where do the existing web plugins end up getting registered now? Or will that come w/ them being split out into separate packages?
Existing plugins should continue working, with a console warning. We'll have to add an upgrade guide for plugins to switch to the new |
I saw that but wasn't sure where the actual registration was happening anymore now that this line is gone: https://github.com/ionic-team/capacitor/pull/3305/files#diff-8aa3e4905a661a3f822d1f6cdf593c15L22 |
Oops, updated! |
I'm still missing where the actual merge/register is being called for the core web plugins? If it's not called somewhere explicitly then the web plugins won't be registered, right? |
I can add it in, but we're going to be splitting out the plugins anyway in the next few days. |
Right that makes sense |
Okay this is good to go. @jcesarmobile? |
This is an implementation of the plugin import proposal. To achieve consistent imports in each platform, I recommend we move the
Plugins
proxy from user code to plugin author code.registerPlugin
should be used to register implementations of plugins in each platformregisterWebPlugin
will continue to work so people can continue using the plugin proxy and the web implementation (we can avoid a breaking change)TODO
add acompat.ts
for legacy (PluginRegistry, etc.)closes: #3306