-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): Add Statusbar.setOverlaysWebView method #2597
Changes from 7 commits
b985032
90d3ae1
81bf08d
7645db5
63735b4
b01c0ed
73299b1
cf90e82
936da9a
2d723ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -1608,6 +1608,11 @@ export interface StatusBarPlugin extends Plugin { | |||||
* Get info about the current state of the status bar | ||||||
*/ | ||||||
getInfo(): Promise<StatusBarInfoResult>; | ||||||
/** | ||||||
* Set whether or not the status bar should overlay the webview to allow usage of the space | ||||||
* around a device "notch" | ||||||
*/ | ||||||
setOverlaysWebView(options: StatusBarOverlaysWebviewOptions): Promise<void>; | ||||||
} | ||||||
|
||||||
export interface StatusBarStyleOptions { | ||||||
|
@@ -1633,6 +1638,11 @@ export interface StatusBarInfoResult { | |||||
visible: boolean; | ||||||
style: StatusBarStyle; | ||||||
color?: string; | ||||||
overlaysWebview: boolean; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change the name to overlaid or overlays, and make it optional because iOS doesn't return it
Suggested change
|
||||||
} | ||||||
|
||||||
export interface StatusBarOverlaysWebviewOptions { | ||||||
overlay: boolean; | ||||||
} | ||||||
|
||||||
export interface StoragePlugin extends Plugin { | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -49,6 +49,11 @@ export class StatusBarExample { | |||||
style: this.isStatusBarLight ? StatusBarStyle.Dark : StatusBarStyle.Light | ||||||
}); | ||||||
this.isStatusBarLight = !this.isStatusBarLight; | ||||||
|
||||||
// Display content under transparent status bar (Android only) | ||||||
Statusbar.setOverlaysWebView({ | ||||||
enabled: true | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. forgot to change the new name here
Suggested change
|
||||||
}) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing ; at the end
Suggested change
|
||||||
} | ||||||
|
||||||
hideStatusBar() { | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the name to overlaid or overlays