Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Storage): explain what the plugin uses under the hood #2058

Merged
merged 1 commit into from
Oct 21, 2019
Merged

docs(Storage): explain what the plugin uses under the hood #2058

merged 1 commit into from
Oct 21, 2019

Conversation

sandstrom
Copy link
Contributor

@sandstrom sandstrom commented Oct 16, 2019 •
edited
Loading

Mention that UserDefaults and SharedPreferences is used under the hood.

@jcesarmobile jcesarmobile changed the title Minor clarification in storage plugin docs docs(Storage): explain what the plugin uses under the hood Oct 21, 2019
jcesarmobile
jcesarmobile approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@jcesarmobile jcesarmobile merged commit 64cc133 into ionic-team:master Oct 21, 2019
@sandstrom sandstrom deleted the patch-2 branch October 21, 2019 15:50
@sandstrom
Copy link
Contributor Author

thanks @jcesarmobile! Would you like to take a look at this other PR of mine?

https://github.com/ionic-team/capacitor/pulls/sandstrom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandstrom @jcesarmobile