New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): mimic cordova's js-module logic when no name attribute #1959

Merged

jcesarmobile merged 1 commit into master from fix-cordova-js-module-name

Sep 16, 2019

Contributor

tlancina commented Sep 14, 2019

Otherwise <js-module>'s with no name are installed as
pluginId.undefined, which can mess with deviceready.

Copies the logic directly from https://github.com/apache/cordova-common/blob/d73d7fab70d2a5110bae174e48065065373732c9/src/PlatformJson.js#L247
and https://github.com/apache/cordova-ios/blob/4562ef5608d57d471dc11212c9f432762886a32d/bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js#L194

Closes #1958.


          fix(cli): mimic cordova's js-module logic when no name attribute

b0c942f

Otherwise `<js-module>`'s with no name are installed as
`pluginId`.`undefined`, which can mess with `deviceready`.

Copies the logic directly from https://github.com/apache/cordova-common/blob/d73d7fab70d2a5110bae174e48065065373732c9/src/PlatformJson.js#L247
and https://github.com/apache/cordova-ios/blob/4562ef5608d57d471dc11212c9f432762886a32d/bin/templates/scripts/cordova/lib/plugman/pluginHandlers.js#L194

Closes #1958.

jcesarmobile approved these changes

View reviewed changes

Member

jcesarmobile left a comment

LGTM

jcesarmobile merged commit 4f50f3f into master

jcesarmobile deleted the fix-cordova-js-module-name branch

September 16, 2019 12:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet