Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android/splash): Avoid glitches on slow devices and respect keep fullscreen flag #1890

Merged
merged 1 commit into from
Aug 22, 2019

Conversation

LeviticusMB
Copy link
Contributor

On slow devices, there is a visual glitch when the splash screen is hidden, which can be avoided by changing the visibility before removing the view.

Additionally, the FLAG_FULLSCREEN should be copied from the window so that the status bar does not appear during the splash, in case <item name="android:windowFullscreen">true</item> was specified in styles.xml.

@jcesarmobile jcesarmobile changed the title Avoid glitches on slow devices and respect keep fullscreen flag, if set. fix(android/splash): Avoid glitches on slow devices and respect keep fullscreen flag Aug 22, 2019
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@jcesarmobile jcesarmobile merged commit 588f51a into ionic-team:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants