Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): add missing format field in CameraPhoto #1798

Merged
merged 1 commit into from
Jul 24, 2019
Merged

fix(android): add missing format field in CameraPhoto #1798

merged 1 commit into from
Jul 24, 2019

Conversation

WIStudent
Copy link
Contributor

According to the typescript definitions the CameraPhoto object should contain a field "format", but it doesn't on android. This PR adds that field and sets its value to "jpeg".

According to the typescript definitions the CameraPhoto object should
contain a field "format", but it doesn't on android. This commit adds
that field and sets its value to "jpeg".
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@jcesarmobile jcesarmobile changed the title Fix missing format field in CameraPhoto on android fix(android): add missing format field in CameraPhoto Jul 24, 2019
@jcesarmobile jcesarmobile merged commit c61d4cb into ionic-team:master Jul 24, 2019
@WIStudent WIStudent deleted the fix-camera-format branch May 29, 2020 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants