feat(splashscreen): Added backgroundColor to Splash Screen plugin. #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mlynch I have managed to add backgroundColor support for iOS. I renamed the configuration key to |
trancee
changed the title
| showSplash(showDuration: showDuration, fadeInDuration: fadeInDuration, fadeOutDuration: fadeOutDuration, autoHide: autoHide, completion: { | ||
| call.success() | ||
| }, isLaunchSplash: false) | ||
| let backgroundColor = call.get("backgroundColor", String.self) |
There was a problem hiding this comment.
It should be like this:
Suggested change
| let backgroundColor = call.get("backgroundColor", String.self) | |
| let backgroundColor = getConfigValue("backgroundColor") as? String ?? nil |
call.get is to get the value from the plugin call, not from the capacitor.config.json
There was a problem hiding this comment.
OK, I have changed it according to your suggestion.
jcesarmobile
requested changes
Jun 19, 2019
|
Something went wrong with the rebase, looks like you didn't pull latest changes. |
Maybe I forgot to include all of the files. I am doing that now. Hopefully that works. |
jcesarmobile
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where you use a different scale type, e.g. CENTER_INSIDE, it is possible that the splash image is smaller than the view itself. The missing parts around the splash image will then be transparent and showing the background of the app. You can now override this by specifying a background color (similar to the cordova splash screen plugin). The value is a simple
#RGBor#ARGBvalue.@mlynch Thank you for your feedback. I am not sure if this config key makes sense on iOS, as it handles splash screens differently. It is necessary on Android because you can change the scale type and it may happen that not the full screen is covered by the splash screen. In those cases, it requires the background color to cover those areas or they will be transparent and showing off the web app which looks ugly.
Basically, I am just following the practice from the Cordova splash screen plugin.