Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Allow to filter incompatible plugins per platform #1645

Merged

Conversation

jcesarmobile
Copy link
Member

and add cordova-plugin-googlemaps as iOS incompatible only.

@jcesarmobile jcesarmobile merged commit dc16b19 into ionic-team:master Jun 7, 2019
@jcesarmobile jcesarmobile deleted the incompatible-per-platform branch June 7, 2019 11:08
@wf9a5m75
Copy link
Contributor

abusing?

@jcesarmobile
Copy link
Member Author

jcesarmobile commented Oct 17, 2019

???
The plugin causes build failures on iOS, this allow people to still use it on Android

If you have made it compatible let us know and we will remove it from the list

@wf9a5m75
Copy link
Contributor

At least, you should list here, not just blocking secretly.
Nobody can not found until inspecting the code.

https://github.com/ionic-team/capacitor/blob/29087ec682c29184efa2d25037cdf542d7c259ac/site/docs-md/cordova/known-incompatible-plugins.md

@jcesarmobile
Copy link
Member Author

When you run update command it tells you the plugin is incompatible, so it’s not a secret. But yeah, I’ll add it to the list

@jcesarmobile
Copy link
Member Author

documented on #2072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants