Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electron): Filesystem.rmdir not using directory #1623

Merged
merged 3 commits into from
Jun 5, 2019
Merged

fix(electron): Filesystem.rmdir not using directory #1623

merged 3 commits into from
Jun 5, 2019

Conversation

27pchrisl
Copy link
Contributor

Update to make rmdir work like mkdir

@27pchrisl 27pchrisl force-pushed the fix-electron-filesystem-rmdir-path branch from b32cbdd to 1bb5a3c Compare June 3, 2019 12:05
jcesarmobile
jcesarmobile approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jcesarmobile jcesarmobile changed the title Electron fix rmdir not using directory fix(electron): Filesystem.rmdir not using directory Jun 5, 2019
@jcesarmobile jcesarmobile merged commit 7549ccc into ionic-team:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@27pchrisl @jcesarmobile @adrm