Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electron): incorrect path being used for Filesystem.stat #1619

Merged

Conversation

27pchrisl
Copy link
Contributor

This fixes an issue where Filesystem.stat used the passed in path, instead of the directory + path combination

@27pchrisl 27pchrisl force-pushed the fix-electron-filesystem-stat-path branch from 3967067 to e242dcb Compare June 3, 2019 11:38
@27pchrisl 27pchrisl force-pushed the fix-electron-filesystem-stat-path branch from e242dcb to 564b33b Compare June 3, 2019 11:47
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@jcesarmobile jcesarmobile changed the title Electron fix incorrect path being used for stat fix(electron): incorrect path being used for Filesystem.stat Jun 5, 2019
@jcesarmobile jcesarmobile merged commit 6625d5e into ionic-team:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants