Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(cli): Allow to add ios platform from windows #1607

Merged
merged 1 commit into from
May 30, 2019
Merged

Fix(cli): Allow to add ios platform from windows #1607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/src/ios/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export async function findXcodePath(config: Config): Promise<string | null> {

export async function checkCocoaPods(config: Config): Promise<string | null> {
config;
if (!await isInstalled('pod')) {
if (!await isInstalled('pod') && config.cli.os === 'mac') {
return 'cocoapods is not installed. For information: https://guides.cocoapods.org/using/getting-started.html#installation';
}
return null;
Expand Down
3 changes: 0 additions & 3 deletions cli/src/tasks/add.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ import chalk from 'chalk';
import { resolve } from 'path';

export async function addCommand(config: Config, selectedPlatformName: string) {
if (selectedPlatformName === 'ios' && config.cli.os !== 'mac') {
logFatal('Not running Mac OS X, can\'t add ios platform');
}

const platformName = await config.askPlatform(
selectedPlatformName,
Expand Down