fix(cli): signing type option issue (#6716)

Co-authored-by: fdliu <[email protected]> Co-authored-by: Mark Anderson <[email protected]>
ionic-team · Aug 3, 2023 · ee0f745 · ee0f745
1 parent cc85df5
commit ee0f745
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 22 deletions.
diff --git a/cli/src/config.ts b/cli/src/config.ts
@@ -239,6 +239,10 @@ async function loadAndroidConfig(
   const buildOptions = {
     keystorePath: extConfig.android?.buildOptions?.keystorePath,
     keystorePassword: extConfig.android?.buildOptions?.keystorePassword,
+    keystoreAlias: extConfig.android?.buildOptions?.keystoreAlias,
+    keystoreAliasPassword:
+      extConfig.android?.buildOptions?.keystoreAliasPassword,
+    signingType: extConfig.android?.buildOptions?.signingType,
     releaseType: extConfig.android?.buildOptions?.releaseType,
   };
 

diff --git a/cli/src/index.ts b/cli/src/index.ts
@@ -174,7 +174,7 @@ export function runProgram(config: Config): void {
               keystorealias,
               keystorealiaspass,
               androidreleasetype,
-              signingtype,
+              signingType,
             },
           ) => {
             const { buildCommand } = await import('./tasks/build');
@@ -185,7 +185,7 @@ export function runProgram(config: Config): void {
               keystorealias,
               keystorealiaspass,
               androidreleasetype,
-              signingtype,
+              signingtype: signingType,
             });
           },
         ),

diff --git a/core/native-bridge.ts b/core/native-bridge.ts
@@ -1065,6 +1065,7 @@ const initBridge = (w: any): void => {
       });
     };
 
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     cap.withPlugin = (_pluginId, _fn) => dummy;
 
     cap.Exception = CapacitorException;

diff --git a/ios/Capacitor/Capacitor/JS.swift b/ios/Capacitor/Capacitor/JS.swift
@@ -19,13 +19,6 @@ internal struct JSCall {
     let pluginId: String
     let method: String
     let callbackId: String
-
-    init(options: [String: Any], pluginId: String, method: String, callbackId: String) {
-        self.options = options
-        self.pluginId = pluginId
-        self.method = method
-        self.callbackId = callbackId
-    }
 }
 
 internal protocol JSResultProtocol {
@@ -64,11 +57,6 @@ internal struct JSResult: JSResultProtocol {
     let call: JSCall
     let result: PluginCallResult?
 
-    init(call: JSCall, result: PluginCallResult?) {
-        self.call = call
-        self.result = result
-    }
-
     func jsonPayload() -> String {
         guard let result = result else {
             return SerializationResult.undefined.rawValue
@@ -101,14 +89,6 @@ internal struct JSResultError: JSResultProtocol {
     let errorCode: String?
     let result: PluginCallResult
 
-    init(call: JSCall, errorMessage: String, errorDescription: String, errorCode: String?, result: PluginCallResult) {
-        self.call = call
-        self.errorMessage = errorMessage
-        self.errorDescription = errorDescription
-        self.errorCode = errorCode
-        self.result = result
-    }
-
     func jsonPayload() -> String {
         var errorDictionary: [String: Any] = [
             "message": self.errorMessage,