Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(android): document plugin variables #204

Merged
merged 6 commits into from
Jan 25, 2021
Merged

docs(android): document plugin variables #204

merged 6 commits into from
Jan 25, 2021

Conversation

imhoffd
Copy link
Contributor

@imhoffd imhoffd commented Jan 20, 2021 •
edited
Loading

I'm not sure if we should document ALL the plugin variables in EVERY plugin, or just the unique ones.

@imhoffd imhoffd marked this pull request as draft January 20, 2021 21:15
@jcesarmobile
Copy link
Member

I think it's ok to only put the ones specific for the plugin as the others are in capacitor/android and are included by default in variables.gradle

@imhoffd
Copy link
Contributor Author

imhoffd commented Jan 21, 2021

Okay 👍

I think we should document the capacitor/android variables somewhere, too 👉 ionic-team/capacitor-docs#50

@imhoffd imhoffd marked this pull request as ready for review January 21, 2021 19:47
jcesarmobile
jcesarmobile requested changes Jan 22, 2021
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should say the default version they use

jcesarmobile
jcesarmobile requested changes Jan 25, 2021
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have removed androidxMaterialVersion from capacitor/android, should be added to camera and action-sheet

@imhoffd imhoffd linked an issue Jan 25, 2021 that may be closed by this pull request
Document android gradle variables #123
Closed
@imhoffd imhoffd merged commit 26500a0 into main Jan 25, 2021
@imhoffd imhoffd deleted the plugin-variables-docs branch January 25, 2021 20:00
@imhoffd imhoffd mentioned this pull request Feb 3, 2021
Closed
hmaretic24 pushed a commit to hmaretic24/capacitor-plugins that referenced this pull request Nov 9, 2022
@imhoffd
docs: document plugin variables (ionic-team#204)
f5491ff
hmaretic24 pushed a commit to hmaretic24/capacitor-plugins that referenced this pull request Jan 20, 2023
@imhoffd
docs: document plugin variables (ionic-team#204)
d94771f
hmaretic24 pushed a commit to hmaretic24/capacitor-plugins that referenced this pull request Apr 25, 2023
@imhoffd @hmaretic24
docs: document plugin variables (ionic-team#204)
f7583d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document android gradle variables
2 participants
@imhoffd @jcesarmobile