Preserve aspect ratio

[imhoffd]

Feature Request

Plugin

Camera

Description

Originally requested by @zyniq82 (ionic-team/capacitor#1952) with an unfinished implementation by @sandstrom (ionic-team/capacitor#2050).

The Camera plugin has strange default behavior when using width and height:

• if I specify both width and height, I'm sure no side is too long, but then the aspect ratio of the resulting image is changed.
• if I specify only width or height, the aspect ratio is retained, but then I don't know if my prescribed value is applied to the longer or shorter side of the image, since I don't know beforehand if the image is in portrait or landscape format.

-- @zyniq82

The default behavior should be to preserve the aspect ratio, even if both width and height are given (this is a breaking change from the core plugin). There can be an option to disable the default behavior, for example preserveAspectRatio (which would default to true).

Platform(s)

iOS, Android

[sandstrom]

I just want to add that not preserving the aspect ratio is a bug and I don't know of any camera plugin/sdk (native, cordova or otherwise) that wouldn't want to preserve aspect ratio of photos when resizing. I think adding a preserveAspectRatio option is a bad idea.

Thanks for opening the issue though, and for your work on Capacitor. I really like capacitor! 😄

[zyniq82]

With the inclusion of ionic-team/capacitor#3309 in Capacitor 2.4.0, I say this is now fixed 🙂
Thank you all for the participation! 🙏

[imhoffd]

Thanks! I created #24 to track the planned preserveAspectRatio default value change.

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the plugin, please create a new issue and ensure the template is fully filled out.