feat(app): return promise in exitApp (#777)

Co-authored-by: jcesarmobile <[email protected]>
ionic-team · Mar 1, 2022 · 38e1efc · 38e1efc
1 parent fe601a5
commit 38e1efc
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/app/README.md b/app/README.md
@@ -92,16 +92,14 @@ const checkAppLaunchUrl = async () => {
 ### exitApp()
 
 ```typescript
-exitApp() => never
+exitApp() => Promise<void>
 ```
 
 Force exit the app. This should only be used in conjunction with the `backButton` handler for Android to
 exit the app when navigation is complete.
 
 Ionic handles this itself so you shouldn't need to call this if using Ionic.
 
-**Returns:** <code>never</code>
-
 **Since:** 1.0.0
 
 --------------------

diff --git a/app/android/src/main/java/com/capacitorjs/plugins/app/AppPlugin.java b/app/android/src/main/java/com/capacitorjs/plugins/app/AppPlugin.java
@@ -61,6 +61,7 @@ public void handleOnBackPressed() {
     @PluginMethod
     public void exitApp(PluginCall call) {
         unsetAppListeners();
+        call.resolve();
         getBridge().getActivity().finish();
     }
 

diff --git a/app/ios/Plugin/AppPlugin.m b/app/ios/Plugin/AppPlugin.m
@@ -4,7 +4,7 @@
 // Define the plugin using the CAP_PLUGIN Macro, and
 // each method the plugin supports using the CAP_PLUGIN_METHOD macro.
 CAP_PLUGIN(AppPlugin, "App",
-           CAP_PLUGIN_METHOD(exitApp, CAPPluginReturnNone);
+           CAP_PLUGIN_METHOD(exitApp, CAPPluginReturnPromise);
            CAP_PLUGIN_METHOD(getInfo, CAPPluginReturnPromise);
            CAP_PLUGIN_METHOD(getLaunchUrl, CAPPluginReturnPromise);
            CAP_PLUGIN_METHOD(getState, CAPPluginReturnPromise);

diff --git a/app/src/definitions.ts b/app/src/definitions.ts
@@ -139,7 +139,7 @@ export interface AppPlugin {
    *
    * @since 1.0.0
    */
-  exitApp(): never;
+  exitApp(): Promise<void>;
 
   /**
    * Return information about the app.

diff --git a/app/src/web.ts b/app/src/web.ts
@@ -12,7 +12,7 @@ export class AppWeb extends WebPlugin implements AppPlugin {
     );
   }
 
-  exitApp(): never {
+  exitApp(): Promise<void> {
     throw this.unimplemented('Not implemented on web.');
   }