fix(unit-tests): allow the components to hydrate #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imhoffd
approved these changes
Jul 31, 2019
Ionitron
added a commit
that referenced
this pull request
Oct 22, 2019
# [2.1.0](v2.0.0...v2.1.0) (2019-10-22) ### Bug Fixes * **routing:** split out routes into routing module ([#181](#181)) ([b13b823](b13b823)) * **unit-tests:** allow the components to hydrate ([#173](#173)) ([4159e59](4159e59)) ### Features * **router:** change to dynamic import ([#176](#176)) ([fbf3627](fbf3627))
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
wand1252
added a commit
to wand1252/angular-toolkit-develop
that referenced
this pull request
Aug 31, 2022
# [2.1.0](ionic-team/angular-toolkit@v2.0.0...v2.1.0) (2019-10-22) ### Bug Fixes * **routing:** split out routes into routing module ([#181](ionic-team/angular-toolkit#181)) ([b13b823](ionic-team/angular-toolkit@b13b823)) * **unit-tests:** allow the components to hydrate ([#173](ionic-team/angular-toolkit#173)) ([4159e59](ionic-team/angular-toolkit@4159e59)) ### Features * **router:** change to dynamic import ([#176](ionic-team/angular-toolkit#176)) ([fbf3627](ionic-team/angular-toolkit@fbf3627))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated how the tests are set up in the starters such that the Ionic components hydrate. The thread of discussion for this can be found here: https://ionicteam.slack.com/archives/C7CGXAVTL/p1564506798491300
Also updates the lint pre-commit hook per some discussions with Dan on getting the commit to work.