fix(routing): split out routes into routing module (#181)

ionic-team · Oct 22, 2019 · b13b823 · b13b823
1 parent 5b611c3
commit b13b823
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 9 deletions.
diff --git a/schematics/page/files/__name@dasherize@if-flat__/__name@dasherize__-routing.module.ts b/schematics/page/files/__name@dasherize@if-flat__/__name@dasherize__-routing.module.ts
@@ -0,0 +1,17 @@
+import { NgModule } from '@angular/core';
+import { Routes, RouterModule } from '@angular/router';
+
+import { <%= classify(name) %>Page } from './<%= dasherize(name) %>.page';
+
+const routes: Routes = [
+  {
+    path: '',
+    component: <%= classify(name) %>Page
+  }
+];
+
+@NgModule({
+  imports: [RouterModule.forChild(routes)],
+  exports: [RouterModule],
+})
+export class <%= classify(name) %>PageRoutingModule {}
diff --git a/schematics/page/files/__name@dasherize@if-flat__/__name@dasherize__.module.ts b/schematics/page/files/__name@dasherize@if-flat__/__name@dasherize__.module.ts
@@ -1,25 +1,19 @@
 import { NgModule } from '@angular/core';
 import { CommonModule } from '@angular/common';
 import { FormsModule } from '@angular/forms';
-import { Routes, RouterModule } from '@angular/router';
 
 import { IonicModule } from '@ionic/angular';
 
-import { <%= classify(name) %>Page } from './<%= dasherize(name) %>.page';
+import { <%= classify(name) %>PageRoutingModule } from './<%= dasherize(name) %>-routing.module';
 
-const routes: Routes = [
-  {
-    path: '',
-    component: <%= classify(name) %>Page
-  }
-];
+import { <%= classify(name) %>Page } from './<%= dasherize(name) %>.page';
 
 @NgModule({
   imports: [
     CommonModule,
     FormsModule,
     IonicModule,
-    RouterModule.forChild(routes)
+    <%= classify(name) %>PageRoutingModule
   ],
   declarations: [<%= classify(name) %>Page]
 })