Now long legend labels do not have ellipsis.

iongroup · Oct 20, 2017 · 429b840 · 429b840
1 parent 01c9891
commit 429b840
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 26 deletions.
diff --git a/CHANGELOG_ION.md b/CHANGELOG_ION.md
@@ -1,5 +1,11 @@
 # plotly.js ION changelog
 
+## [1.28.3-ion43] -- 2017-10-20
+
+### Fix part I
+- Legend labels do not have any more ellipsis
+
+
 ## [1.28.3-ion42] -- 2017-10-19
 
 ### Fixed

diff --git a/dist_ion/plotly-ion.js b/dist_ion/plotly-ion.js
@@ -22727,16 +22727,10 @@ function drawTexts(g, gd) {
         trace = legendItem.trace,
         isPie = Registry.traceIs(trace, 'pie'),
         traceIndex = trace.index,
-        name = isPie ? legendItem.label : trace.name;
-
-        // ion: legend label ellipsis
-        var maxCharLength = 20;                    
-        var drawnText = name;
-        if (name.length > maxCharLength) {
-            var firstLen = Math.floor(maxCharLength / 2);
-            var lastLen = maxCharLength - firstLen - 1;
-            drawnText = drawnText.substr(0, firstLen) + '…' + drawnText.substr(-lastLen);
-        }
+        name = isPie ? legendItem.label : trace.name;      
+
+    // ion
+    var drawnText = name;        
 
     var text = g.selectAll('text.legendtext')
         .data([0]);

diff --git a/dist_ion/plotly-ion.min.js b/dist_ion/plotly-ion.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "plotly.js",
-  "version": "1.28.3-ion42",
+  "version": "1.28.3-ion43",
   "description": "The open source javascript graphing library that powers plotly",
   "license": "MIT",
   "main": "./lib/index.js",

diff --git a/src/components/legend/draw.js b/src/components/legend/draw.js
@@ -382,16 +382,10 @@ function drawTexts(g, gd) {
         trace = legendItem.trace,
         isPie = Registry.traceIs(trace, 'pie'),
         traceIndex = trace.index,
-        name = isPie ? legendItem.label : trace.name;
-
-        // ion: legend label ellipsis
-        var maxCharLength = 20;                    
-        var drawnText = name;
-        if (name.length > maxCharLength) {
-            var firstLen = Math.floor(maxCharLength / 2);
-            var lastLen = maxCharLength - firstLen - 1;
-            drawnText = drawnText.substr(0, firstLen) + '…' + drawnText.substr(-lastLen);
-        }
+        name = isPie ? legendItem.label : trace.name;      
+
+    // ion
+    var drawnText = name;        
 
     var text = g.selectAll('text.legendtext')
         .data([0]);