Skip to content

Commit

Permalink
GUI throws unhandled exception intermittently when a user changes sca…
Browse files Browse the repository at this point in the history
…tter chart to world chart. Due to bad params passed to map chart.
  • Loading branch information
michelezanda committed Mar 26, 2018
1 parent b327680 commit 1a1db98
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 13 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG_ION.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# plotly.js ION changelog

## [1.33.1-ion7] -- 2018-03-26

### [ARCBUGS-4454] GUI throws unhandled exception intermittently when a user changes scatter chart to world chart. Due to bad params passed to map chart.
### [CORESDK-3299] Charts: tooltip customization for boxes in boxplots and candles in candlestick. Fix for a missing textbox parameter.


## [1.33.1-ion6] -- 2018-03-23

### [CORESDK-3299] Charts: tooltip customization for boxes in boxplots and candles in candlestick. Fix due to double series for positive vs negative candles.
Expand Down
5 changes: 3 additions & 2 deletions dist_ion/plotly-ion.js
Original file line number Diff line number Diff line change
Expand Up @@ -32816,7 +32816,7 @@ exports.svgAttrs = {
var Plotly = require('./plotly');

// package version injected by `npm run preprocess`
exports.version = '1.33.1-ion6';
exports.version = '1.33.1-ion7';

// inject promise polyfill
require('es6-promise').polyfill();
Expand Down Expand Up @@ -70902,8 +70902,9 @@ module.exports = function hoverPoints(pointData, xval, yval) {
var project = geo.project;

function distFn(d) {
var lonlat = d.lonlat;
var lonlat = d && d.lonlat;

if (!lonlat) return Infinity; // ARCBUGS-4454 : d.lonlat can be not defined.
if(lonlat[0] === BADNUM) return Infinity;
if(isLonLatOverEdges(lonlat)) return Infinity;

Expand Down
2 changes: 1 addition & 1 deletion dist_ion/plotly-ion.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "plotly.js",
"version": "1.33.1-ion6",
"version": "1.33.1-ion7",
"description": "The open source javascript graphing library that powers plotly",
"license": "MIT",
"main": "./lib/index.js",
Expand Down
12 changes: 6 additions & 6 deletions samples/chart_perf.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var trace1 = {
//y: [2, 3, 4, 6,7, 8, 9, 10, 11, 12, 13],
y: [-40, 50, 60],
x: ['2017-01-04', '2017-01-05', '2017-01-06'],
y: [2, 3, 4, 6,7, 8, 9, 10, 11, 12, 13],
//y: [-40, 50, 60],
//x: ['2017-01-04', '2017-01-05', '2017-01-06'],
// y: [-40, 50, 60],
close: [116.019997, 116.610001, 117.910004],

Expand All @@ -19,10 +19,10 @@ var trace1 = {
text: ['ciao1', 'ciao2', 'ciao3', 'ciao3', 'ciao3', 'ciao3', 'ciao3'],
textbox: [['goofy0', 'goofy1', 'goofy2', 'goofy3', 'goofy4'], ['goofy5', 'goofy6', 'goofy7']],

hoverinfo: 'y+text',
hoverinfo: 'text',

boxpoints: 'all',
type: 'candlestick',
boxpoints: 'None',
type: 'box',
name: 'MZ',
opacity: 0.5
};
Expand Down
2 changes: 1 addition & 1 deletion src/assets/geo_assets.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ var saneTopojson = require('sane-topojson');


// package version injected by `npm run preprocess`
exports.version = '1.33.1-ion6';exports.topojson = saneTopojson;
exports.version = '1.33.1-ion7';exports.topojson = saneTopojson;
2 changes: 1 addition & 1 deletion src/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
var Plotly = require('./plotly');

// package version injected by `npm run preprocess`
exports.version = '1.33.1-ion6';
exports.version = '1.33.1-ion7';

// inject promise polyfill
require('es6-promise').polyfill();
Expand Down
3 changes: 2 additions & 1 deletion src/traces/scattergeo/hover.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ module.exports = function hoverPoints(pointData, xval, yval) {
var project = geo.project;

function distFn(d) {
var lonlat = d.lonlat;
var lonlat = d && d.lonlat;

if (!lonlat) return Infinity; // ARCBUGS-4454 : d.lonlat can be not defined.
if(lonlat[0] === BADNUM) return Infinity;
if(isLonLatOverEdges(lonlat)) return Infinity;

Expand Down

0 comments on commit 1a1db98

Please sign in to comment.