Replace pickled dataframes #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nimoto_scores.pickle
… the 100 example spectra.
…his can crash when internet is lacking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step towards #218, we need to replace all the use of pickled pandas files, since these are not backwards compatible with pandas 2.0.
We cannot yet replace the embeddings. Trying to do this gives many issues (e.g. ms2library is difficult to fix, slighlty different formats of indexes etc.) this is not worth it now, since we have to update this to a different storage method over pickle anyway. see #191
In this PR all other pickled files are replaced with csv files or removed entirely, since they were not needed.