Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate config from index_m to jsonConfig #654

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

Jey-Cee
Copy link
Member

@Jey-Cee Jey-Cee commented Oct 14, 2024

No description provided.

@mcm1957
Copy link
Member

mcm1957 commented Oct 14, 2024

@Jey-Cee
there are merge conflicts

@mcm1957
Copy link
Member

mcm1957 commented Oct 14, 2024

@foxriver76

As registered maintainer (https://github.com/iobroker-community-adapters/info#maintainers) please review / merge and create a new release if OK.

@foxriver76
Copy link
Member

On mobile it looks okay, I just think the create user button and the info text should be aligned vertically to each other

grafik

grafik

For desktop especially maybe we should put the create user info text already in a new line, currently it looks a bit hard to follow with the eyes imo.

And as the button for "find bridges" is now gone, could we maybe have an indicator while it is currently searching for the bridge or is it too hard to implement with json config?

@mcm1957
Copy link
Member

mcm1957 commented Oct 15, 2024

Please note that some (minor in my oppinion) code change is required (and included) too.

@Jey-Cee
Copy link
Member Author

Jey-Cee commented Oct 15, 2024

And as the button for "find bridges" is now gone, could we maybe have an indicator while it is currently searching for the bridge or is it too hard to implement with json config?

That was not possible, but i think the autocompleteSendTo should bring the this feature by its self like the sendTo it already has. Therefore i opened an issue: ioBroker/ioBroker.admin#2770

@Jey-Cee
Copy link
Member Author

Jey-Cee commented Oct 15, 2024

On mobile it looks okay, I just think the create user button and the info text should be aligned vertically to each other

Without extra CSS styles that looks not very well and we loose space which leads to longer ways to scroll.
And i think we should avoid using own CSS as this can break in future or on display resolutions we did not tested.

How is it with this?
sm
grafik
md
grafik
lg
grafik
xl
grafik

@Jey-Cee
Copy link
Member Author

Jey-Cee commented Oct 15, 2024

Reminder: After this PR is merged the Text has to be adjusted in weblate.

@foxriver76
Copy link
Member

On mobile it looks okay, I just think the create user button and the info text should be aligned vertically to each other

Without extra CSS styles that looks not very well and we loose space which leads to longer ways to scroll. And i think we should avoid using own CSS as this can break in future or on display resolutions we did not tested.

How is it with this? sm grafik md grafik lg grafik xl grafik

That looks a lot cleaner to me.

@mcm1957
Copy link
Member

mcm1957 commented Oct 15, 2024

Reminder: After this PR is merged the Text has to be adjusted in weblate.

which text has to be adjusted at weblate?
changes at i18n will normally loaded into wwblate anyway.

@Jey-Cee
Copy link
Member Author

Jey-Cee commented Oct 15, 2024

@mcm1957 I had to revert it while there where merge issues on i18n files.

"Turn On with Others": "Einschalten mit anderen states als `on` und `bri`",
"error creating user: ": "Fehler beim Erzeugen des Benutzers: ",
"error finding bridge": "Fehler beim Finden der Brücke",
"ignoreOsram": "Ignoriere Osram",

@foxriver76 foxriver76 merged commit 3fa696e into iobroker-community-adapters:master Oct 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants