Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest jarvis for latest repository #919

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Suggest jarvis for latest repository #919

merged 1 commit into from
Sep 19, 2020

Conversation

Zefau
Copy link
Contributor

@Zefau Zefau commented Sep 13, 2020

No description provided.

@GermanBluefox
Copy link
Contributor

Automated adapter checker

ioBroker.jarvis

Downloads Number of Installations (latest)
NPM

  • ❗ [E145] No news found for actual version 1.0.0-rc.2
  • ❗ [E300] Not found on travis. Please setup travis
  • 👀 [W400] Cannot find "jarvis" in latest repository

Add comment "RE-CHECK!" to start check anew

@GermanBluefox GermanBluefox added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Sep 13, 2020
@ioBroker ioBroker deleted a comment from Apollon77 Sep 13, 2020
@Zefau
Copy link
Contributor Author

Zefau commented Sep 13, 2020

No news found for actual version 1.0.0-rc.2

1.0.0-rc.2 is only on Github, not npm. News for 1.0.0-rc.1 is available.

[E300] Not found on travis. Please setup travis

It is on pro, see https://travis-ci.com/Zefau/ioBroker.jarvis

[W400] Cannot find "jarvis" in latest repository

Trying with this issue 🥇

@Zefau
Copy link
Contributor Author

Zefau commented Sep 14, 2020

@Apollon77

@Zefau
Copy link
Contributor Author

Zefau commented Sep 19, 2020

Is it actually possible to check branches (https://github.com/Zefau/ioBroker.jarvis/tree/v1.0.x) with https://adapter-check.iobroker.in/ ?

@Apollon77
Copy link
Collaborator

No, adapter checker always check master

@Zefau
Copy link
Contributor Author

Zefau commented Sep 19, 2020

Would you merge though?

No news found for actual version 1.0.0-rc.2

1.0.0-rc.2 is only on Github, not npm. News for 1.0.0-rc.1 is available.

[E300] Not found on travis. Please setup travis

It is on pro, see https://travis-ci.com/Zefau/ioBroker.jarvis

[W400] Cannot find "jarvis" in latest repository

Trying with this issue 🥇

@Apollon77
Copy link
Collaborator

@Zefau
Some comments (I checked the 1.0.x branch):

  • if unit tests fail that way as they do then do not run them ... or fix them ;-)
  • For now ok, but at least in the io-package we should have all languages translated that are standard! Please change that till stable - or we need to discuss again about this in the community; also having links only as version new is not that user friendly and shoukd be changed
  • "installedFrom" needs to be removed from io-package!! Please fix that
  • Note: https://github.com/Zefau/ioBroker.jarvis/blob/v1.0.x/lib/library.js#L302 ... "delete this._STATES[key]" is the official command ... I do not know if there is a difference to set to undefined ...

@Apollon77 Apollon77 merged commit 580c47a into ioBroker:master Sep 19, 2020
@Zefau
Copy link
Contributor Author

Zefau commented Sep 20, 2020

Unit test runs successful, see https://travis-ci.com/github/Zefau/ioBroker.jarvis/branches

Where do you see it failing?

Translation will be done, even though I'm not a friend of Google translated texts.

Io package will be cleaned soon.

Is there something wrong with delete from your perspective? It is like setting it to undefined, but that is addressed in the code.

@Apollon77
Copy link
Collaborator

For delete vs undefined I really do not know. It should be the same effect, but „delete“ is the official way to delete a value. Maybe there are differences in the deeeeeeep insides ... that’s why it was just a note.

Tests do not fail but when you check travis log output from Master i saw unhandled promise rejection on unit tests.

@Zefau
Copy link
Contributor Author

Zefau commented Sep 20, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants