Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xmpp #1284

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Remove xmpp #1284

merged 2 commits into from
Dec 8, 2023

Conversation

chris34
Copy link
Member

@chris34 chris34 commented Dec 3, 2023

Remove XMPP-dependencies from Inyoka, as it's not used anymore.
See the commit messages for more details

needs inyokaproject/theme-ubuntuusers#489

XMPP was not used anymore, since it was made an optional dependency.

 - database migration
   - remove not needed user settings
   - remove hidden jabber-ids for privacy, as there is no reason
     to save them anymore (previously, they could be used for
     notifications)
   - test the new migrations
 - Use JabberField in model of user\
   (In the form it uses a custom jabber form field that
   validates the jabber-id.)
   - uses RegexValidator
   - added basic tests
Thus, we can now test migrations.
Copy link
Contributor

@encbladexp encbladexp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@chris34 chris34 merged commit 4defec5 into inyokaproject:staging Dec 8, 2023
2 checks passed
@chris34 chris34 deleted the rm-xmpp branch December 8, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants