Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements: MarkupSafe==1.0 incompatible with setuptools > 45.3.0 #1142

Closed
sebix opened this issue Aug 30, 2020 · 2 comments
Closed

Requirements: MarkupSafe==1.0 incompatible with setuptools > 45.3.0 #1142

sebix opened this issue Aug 30, 2020 · 2 comments

Comments

@sebix
Copy link
Member

sebix commented Aug 30, 2020

We pinned MarkupSafe to version 1.0, but it is incompatible with current setuptools versions:

Collecting MarkupSafe==1.0
  Downloading MarkupSafe-1.0.tar.gz (14 kB)
    ERROR: Command errored out with exit status 1:
     command: /home/sebastianw/.venvs/inyoka3/bin/python3 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-d689mqoy/MarkupSafe/setup.py'"'"'; __file__='"'"'/tmp/pip-install-d689mqoy/MarkupSafe/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-gj7abmaq
         cwd: /tmp/pip-install-d689mqoy/MarkupSafe/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-d689mqoy/MarkupSafe/setup.py", line 6, in <module>
        from setuptools import setup, Extension, Feature
    ImportError: cannot import name 'Feature' from 'setuptools' (/home/sebastianw/.venvs/inyoka3/lib64/python3.8/site-packages/setuptools/__init__.py)
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
WARNING: You are using pip version 20.1.1; however, version 20.2.2 is available.
You should consider upgrading via the '/home/sebastianw/.venvs/inyoka3/bin/python3 -m pip install --upgrade pip' command.

pallets/markupsafe#116

setuptools versions <= 45.3.0 works

@chris34
Copy link
Member

chris34 commented Aug 30, 2020

Please try, if the problem occurs with #1143, too.

chris34 added a commit that referenced this issue Sep 3, 2020
MarkupSafe==1.0 was incompatible with setuptools > 45.3.0, see #1142

According to my ag-searches MarkupSafe is only used in jinja and not in
Inyoka, directly. So bump it to the newest version, that resolves the
issue.
@chris34
Copy link
Member

chris34 commented Sep 3, 2020

Fixed via 5547a2a

@chris34 chris34 closed this as completed Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants