feat(reflect): Add method to modify the schema after processing #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlown
reviewed
Nov 6, 2022
reflect.go
Outdated
| // Function to be run after the schema has been generated. | ||
| // this will let you modify a schema afterwards | ||
| type postSchemaImpl interface { | ||
| JSONSchemaPost(*Schema) |
There was a problem hiding this comment.
I'm not totally convinced on the name... "Post" just isn't obvious enough in my opinion.
There was a problem hiding this comment.
I think JSONSchemaExtend is best. If you're good with that I can rename it
There was a problem hiding this comment.
JSONSchemaExtension is perhaps more grammatically and semantically correct :-) (naming things 🤦 )
There was a problem hiding this comment.
I liked JSONSchemaExtend better, but your choice. Just let me know your final answer and I'll update the PR
There was a problem hiding this comment.
Cool, lets go with JSONSchemaExtend!
There was a problem hiding this comment.
Alright, renamed
* main: Allow for = character in extra property values Add test for anyof Add support for parsing anyof_type Add tests for anyof support Add support for parsing anyof_required
samlown
approved these changes
Nov 8, 2022
| var customType = reflect.TypeOf((*customSchemaImpl)(nil)).Elem() | ||
| var extendType = reflect.TypeOf((*extendSchemaImpl)(nil)).Elem() |
There was a problem hiding this comment.
It's the same length as customType 😍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is very similar to #52 but moves the call to after the default schema builder has run.
This allows struct properties to be modified easily.