Use additionalProperties instead of patternProperties #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi all, is this PR blocked for some reason? I'd like to have this, if needed also with some options to enable or not the additionalProperties field instead of the patternProperties. In my use case, I created gswagger based on this lib to generate OpenAPI spec based on struct. OpenAPI spec <3.1 does not support the patternProperties keyword, so using |
samlown
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how Go maps with non-integer keys are represented by jsonschema to use
additionalPropertiesinstead ofpatternProperties, which is more semantically appropriate and easier to read. (It also happens to be what is supported by redocly-cli at the moment, see Redocly/redocly-cli#792.)