feat(ui, worker): add invocation progress events to model loading #7286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
requested review from
psychedelicious,
blessedcoolant,
hipsterusername and
brandonrising
as code owners
github-actions
bot
added
python
psychedelicious
force-pushed
the
maryhipp/invocation-progress-ui
branch
from
683d3b9
to
fccc87a
Compare
- Pass in the `UtilInterface` to the `ModelsInterface` so we can call the simple `signal_progress` method instead of the complicated `emit_invocation_progress` method. - Only emit load events when starting to load - not after. - Add more detail to the messages, like submodel type
- Tweak layout/styling of alerts for consistent spacing - Add percentage to message if it has percentage - Only show events if the destination is canvas (so workflows events are hidden for example)
- Add `invocationProgressAlert` as a disable-able feature. Hide the alert and the setting in system settings when disabled. - Fix merge conflict
psychedelicious
force-pushed
the
maryhipp/invocation-progress-ui
branch
from
fccc87a
to
283a966
Compare
psychedelicious
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / Discussions
QA Instructions
Invoke to either gallery or canvas, see invocation progress details (model loading, denoising)
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)