Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IPVC-2283): mitochondrial transcript workflow #20

Merged
merged 38 commits into from
Apr 9, 2024

Conversation

nvta1209
Copy link

@nvta1209 nvta1209 commented Apr 5, 2024

  • define workflow steps as a series of docker commands
  • remove docker wrapper scripts
  • separate steps for uta extract and load (run-uta-build.sh became the load step sbin/uta-load) and seqrepo load
  • reuse load step in mito workflow
  • fix strand type in mito processing script

@nvta1209 nvta1209 requested review from sptaylor and bsgiles73 April 5, 2024 21:38
Copy link

@bsgiles73 bsgiles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Just one requested change.

sbin/uta-extract Outdated
tee "$log_dir/filter_exonset_transcripts.log"

# move fasta files into same dir
cp $ncbi_dir/refseq/H_sapiens/mRNA_Prot/human.*.rna.fna.gz $working_dir/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could be hard links.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed to hard links, but the linked files turned out effectively to be copies. The inode numbers were different (when inspected with ls -i). I suspect it has something to do with hard linking across docker volume mounts. I'll leave the hard linking in since the workflow still runs fine.

@nvta1209 nvta1209 requested a review from bsgiles73 April 9, 2024 07:32
Copy link

@bsgiles73 bsgiles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the commit.

@bsgiles73 bsgiles73 merged commit d65d764 into main Apr 9, 2024
1 check passed
@bsgiles73 bsgiles73 deleted the IPVC-2283-mito-workflow branch April 9, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants