-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IPVC-2283): mitochondrial transcript workflow #20
Conversation
…o step can come after extract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. Just one requested change.
sbin/uta-extract
Outdated
tee "$log_dir/filter_exonset_transcripts.log" | ||
|
||
# move fasta files into same dir | ||
cp $ncbi_dir/refseq/H_sapiens/mRNA_Prot/human.*.rna.fna.gz $working_dir/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These could be hard links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed to hard links, but the linked files turned out effectively to be copies. The inode numbers were different (when inspected with ls -i
). I suspect it has something to do with hard linking across docker volume mounts. I'll leave the hard linking in since the workflow still runs fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the commit.
run-uta-build.sh
became the load stepsbin/uta-load
) and seqrepo load