Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross and other toolbar commands (brightness, move, rotate, ...) enabled simultaneously #771

Open
vhosouza opened this issue May 15, 2024 · 4 comments
Open

Cross and other toolbar commands (brightness, move, rotate, ...) enabled simultaneously #771

vhosouza opened this issue May 15, 2024 · 4 comments
Labels
bug neuronavigation Issues related to neuronavigation software

Comments

@vhosouza
Copy link
Member

If the Image "Start registration" button is enabled, it is possible to click and activate simultaneously the other toolbar buttons (brightness, move, rotate, etc..).

This behavior is not desired and should be such that:

When the Image "Start registration" is active, the other buttons are disabled until the registration is finished. Users should be warned about that. This can cause confusion because it is easy to forget the "Start registration" enabled and it is very difficult to realize that the functionality of brightness, rotate, and pan, adjustments are not working because of that.
@vhosouza vhosouza added bug neuronavigation Issues related to neuronavigation software labels May 15, 2024
@bhavana-github-acc
Copy link

Hey can I be assigned this issue?

@bhavana-github-acc
Copy link

Ok I will work on this issue if that is fine?

@bhavana-github-acc
Copy link

Ok I have started working on part of the issue and am working on the second part now.

bhavana-github-acc added a commit to bhavana-github-acc/invesalius3 that referenced this issue Aug 19, 2024
@bhavana-github-acc
Disable toolbar functionalities during registration; partial resoluti…
a10f846 
…on of issue invesalius#771

- Updated the ObjectToolBar class to disable toolbar buttons (zoom, rotate, move, etc.) when StartRegistration is active.
- Passed an argument from StartRegistration to _EnableState to manage toolbar state based on registration activity.
- Attempted to implement a warning message popup using the wx library to notify users that toolbar buttons are disabled when 'StartRegistration' is active, but was unable to get the popup to work even after many tries.

This commit addresses part of issue invesalius#771 by disabling toolbar functionality during 'StartRegistration'. Further changes are needed to implement the warning message.
@bhavana-github-acc bhavana-github-acc mentioned this issue Aug 19, 2024
Open
bhavana-github-acc added a commit to bhavana-github-acc/invesalius3 that referenced this issue Aug 20, 2024
@bhavana-github-acc
Disable toolbar functionalities during registration; partial solution…
8a7273c 
… to issue invesalius#771
@bhavana-github-acc bhavana-github-acc mentioned this issue Aug 20, 2024
Open
@bhavana-github-acc
Copy link

bhavana-github-acc commented Aug 20, 2024 •
edited
Loading

Hi, I have created a PR for a part of this issue that I was able to solve here: Partial-Disable toolbar functionalities during 'Start Registration' - 771 #826 . Please review it and please let me know if there are any issues with it; I will work again on it. Thank you for your time.

Please Note! The PR has made some formatting changes such as extra spaces and quote replacements. These were automatically applied and are not related to the functional changes. Please let me know if this harms the code in any way.
I have made changes only to the frame.py and task_navigator.py files. I was using PyCharm for the fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug neuronavigation Issues related to neuronavigation software
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vhosouza @bhavana-github-acc