fix: add native ad compatibility layer #687
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated codes to include generated native code by codegen(Reference: https://reactnative.dev/docs/the-new-architecture/codegen-cli#including-generated-code-into-libraries). By doing this, as the generated code is always included in npm artifact(and not rely on the app to run codegen for us), we can support lower react native(or @react-native/codegen) version. Also removed unnecessary constructor passing contexts in classes extending ViewGroupManager, which breaks build in rn version lower than 0.75. Fixes #678
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~687 Documentation is deployed and generated using docs.page. |
|
Waiting for response of a issue about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated codes to include generated native code by codegen(Reference: https://reactnative.dev/docs/the-new-architecture/codegen-cli#including-generated-code-into-libraries). By doing this, as the generated code is always included in npm artifact(and not rely on the app to run codegen for us), we can support lower react native(or @react-native/codegen) version.
Also I removed unnecessary constructor passing contexts in classes extending ViewGroupManager, which breaks android build in rn version lower than 0.75.
Related issues
Fixes #678
Release Summary
Checklist
and followed the process outlined there for submitting PRs.
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
Think
react-native-google-mobile-adsis great? Please consider supporting the project with any of the below:Invertaseon Twitter