-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update example to rn 0.76.2 / bump react-native dep #656
Conversation
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~656 Documentation is deployed and generated using docs.page. |
9ca6ec9
to
5aa5999
Compare
Thanks for this! I went to check the current example and this one and saw a couple other things I fixed up in separate commits, it will tangle with this one though, so I rebased this on top of those fixes and I have it all working locally but need to re-push it here then I can merge it |
should be slightly faster, otherwise should have no effect
5aa5999
to
9e431fb
Compare
Thanks for your patience - the update to react-native was nice, I just noticed a few things related to detox and the iPhone attempted in test etc that were either outdated or not working so wanted to take the opportunity since I was already in there testing the PR. All tiny but they make the various run scripts in package.json all work +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just waiting on CI, hopefully it goes green, then anyone can+should merge...
rebase+merge should work as well, they are all conventional commits
@wjaykim ready to go / unblock that part of your native add PR 🚂 |
🎉 This PR is included in version 14.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Updated react native to 0.76.2.
Related issues
#650 is worked on top of this branch, so this change must be merged before review and merge of the NativeAd branch.
Release Summary
Checklist
and followed the process outlined there for submitting PRs.
Android
iOS
e2e
tests added or updated in__tests__e2e__
jest
tests added or updated in__tests__
Test Plan
Think
react-native-google-mobile-ads
is great? Please consider supporting the project with any of the below:Invertase
on Twitter