Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update example to rn 0.76.2 / bump react-native dep #656

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

wjaykim
Copy link
Collaborator

@wjaykim wjaykim commented Nov 20, 2024

Description

Updated react native to 0.76.2.

Related issues

#650 is worked on top of this branch, so this change must be merged before review and merge of the NativeAd branch.

Release Summary

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

Copy link

docs-page bot commented Nov 20, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-mobile-ads~656

Documentation is deployed and generated using docs.page.

@wjaykim wjaykim force-pushed the @wjaykim/rn-76 branch 2 times, most recently from 9ca6ec9 to 5aa5999 Compare November 20, 2024 17:27
@mikehardy
Copy link
Collaborator

Thanks for this! I went to check the current example and this one and saw a couple other things I fixed up in separate commits, it will tangle with this one though, so I rebased this on top of those fixes and I have it all working locally but need to re-push it here then I can merge it

@mikehardy
Copy link
Collaborator

Thanks for your patience - the update to react-native was nice, I just noticed a few things related to detox and the iPhone attempted in test etc that were either outdated or not working so wanted to take the opportunity since I was already in there testing the PR. All tiny but they make the various run scripts in package.json all work

+1

@mikehardy mikehardy added the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Nov 21, 2024
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just waiting on CI, hopefully it goes green, then anyone can+should merge...
rebase+merge should work as well, they are all conventional commits

@mikehardy mikehardy merged commit feefff7 into main Nov 21, 2024
12 checks passed
@mikehardy mikehardy removed the workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready label Nov 21, 2024
@mikehardy
Copy link
Collaborator

@wjaykim ready to go / unblock that part of your native add PR 🚂

@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 14.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants